Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoch progress bar only showing training steps #1386

Closed
VitorGuizilini opened this issue Apr 6, 2020 · 8 comments
Closed

Epoch progress bar only showing training steps #1386

VitorGuizilini opened this issue Apr 6, 2020 · 8 comments
Assignees
Labels
discussion In a discussion stage feature Is an improvement or enhancement help wanted Open to be worked on
Milestone

Comments

@VitorGuizilini
Copy link
Contributor

Maybe I am missing something obvious, but my epoch progress bar also includes validation steps. This means that, when one of my training epochs is over the progress bar is still around half-way through the number of steps, and then a validation progress bar starts and both increase at the same time.

It makes sense that an epoch should end when training and validation are over, but is there a way to decouple these two, so there is a bar only for training (the epoch progress bar) and another only for validation?

@VitorGuizilini VitorGuizilini added feature Is an improvement or enhancement help wanted Open to be worked on labels Apr 6, 2020
@Borda
Copy link
Member

Borda commented Apr 8, 2020

@PyTorchLightning/core-contributors any strong opinion about the need to split train/valid progress bars? we may have it as an option for a user to chose...?

@Borda Borda added discussion In a discussion stage information needed labels Apr 8, 2020
@williamFalcon
Copy link
Contributor

@vguizilini we originally had it this way, but we chose to make it the way you see with the two progress bars. What about the other way do you prefer?

Maybe we can just make a callback for the progress bar that lets users configure their own options for it?

@Borda or @awaelchli do you want to do this?

@Borda
Copy link
Member

Borda commented Apr 8, 2020

I this that moving progress bar to a callback was discussed already #765 (comment)

@Borda Borda added this to the 0.7.3 milestone Apr 8, 2020
@awaelchli
Copy link
Contributor

I like the idea of having it as callback. I could look into it this weekend and try to do what @hadim suggested. But I suspect I won't be able to finish it in time for next release I'm afraid.

@Borda
Copy link
Member

Borda commented Apr 8, 2020

there is release these days, so I think we are very fine with having it in next 0.7.3

@vguizilini how do you feel about this suggestion with progress bar as callback so you can later customise it on your own...?

@VitorGuizilini
Copy link
Contributor Author

@Borda I am fine with implementing the progress bar as a callback, thanks!

@awaelchli
Copy link
Contributor

We introduced a callback for the progress bar #1450 . It can be customized and extended by the user. See https://pytorch-lightning.readthedocs.io/en/latest/callbacks.html#progress-bars

@Borda Borda modified the milestones: 0.7.4, 0.7.5 Apr 24, 2020
@Borda Borda modified the milestones: 0.7.6, 0.8.0, 0.7.7 May 12, 2020
@Borda Borda modified the milestones: 0.7.7, 0.8.0 May 26, 2020
@Borda Borda modified the milestones: 0.8.0, 0.9.0 Jun 9, 2020
@awaelchli
Copy link
Contributor

do we need to do anything more? or can it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion In a discussion stage feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

4 participants