From d2a4da2ace7a2fb6ced527e38670a0b066667289 Mon Sep 17 00:00:00 2001 From: Brendan Fahy Date: Mon, 6 Jul 2020 00:42:56 +0000 Subject: [PATCH] don't test remote paths if windows --- tests/trainer/test_trainer.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/trainer/test_trainer.py b/tests/trainer/test_trainer.py index 01b6e0d77814c4..d33d907dca7e73 100644 --- a/tests/trainer/test_trainer.py +++ b/tests/trainer/test_trainer.py @@ -1,6 +1,7 @@ import glob import math import os +import platform import pickle import sys import types @@ -968,7 +969,10 @@ def aws_credentials(): os.environ['AWS_SESSION_TOKEN'] = 'testing' -@pytest.mark.skipif(version.parse(tensorboard.__version__) < version.parse('2.0'), reason="remote paths require tensorboard>=2.0") +@pytest.mark.skipif(platform.system() == "Windows", + reason="Saving to remote paths is not supported on Windows") +@pytest.mark.skipif(version.parse(tensorboard.__version__) < version.parse('2.0'), + reason="remote paths require tensorboard>=2.0") def test_trainer_s3_path(aws_credentials): model = EvalModelTemplate() with mock_s3():