From 45903aee8a5a099ff27528c4952ae415c01ef93b Mon Sep 17 00:00:00 2001 From: Jirka Date: Fri, 19 Jun 2020 14:13:14 +0200 Subject: [PATCH] test --- CHANGELOG.md | 2 +- tests/test_deprecated.py | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 119f67b3dc21b..2649abc02d54e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -74,7 +74,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). * `test_percent_check` in favour of `limit_test_batches` - Deprecated `ModelCheckpoint`'s attributes `best` and `kth_best_model` ([#1799](https://github.com/PyTorchLightning/pytorch-lightning/pull/1799)) - Dropped official support/testing for older PyTorch versions <1.3 ([#1917](https://github.com/PyTorchLightning/pytorch-lightning/pull/1917)) -- Deprecated Trainer `proc_rank` in favour of `global_rank` ([#2166](https://github.com/PyTorchLightning/pytorch-lightning/pull/2166), ) +- Deprecated Trainer `proc_rank` in favour of `global_rank` ([#2166](https://github.com/PyTorchLightning/pytorch-lightning/pull/2166), [#2269](https://github.com/PyTorchLightning/pytorch-lightning/pull/2269)) ### Removed diff --git a/tests/test_deprecated.py b/tests/test_deprecated.py index be2fda9c905ba..c2b9295c5b495 100644 --- a/tests/test_deprecated.py +++ b/tests/test_deprecated.py @@ -44,6 +44,12 @@ def test_tbd_remove_in_v0_10_0_trainer(): with pytest.deprecated_call(match='v0.10.0'): assert trainer.test_percent_check == rnd_val + trainer = Trainer() + with pytest.deprecated_call(match='v0.10.0'): + trainer.proc_rank = 0 + with pytest.deprecated_call(match='v0.10.0'): + assert trainer.proc_rank == trainer.global_rank + def test_tbd_remove_in_v0_9_0_trainer(): # test show_progress_bar set by progress_bar_refresh_rate