From 3af4994d5a84bc80738b50983b4b42c3eb946433 Mon Sep 17 00:00:00 2001 From: Mateusz Pieniak <31375424+mateuszpieniak@users.noreply.github.com> Date: Wed, 27 May 2020 01:06:06 +0200 Subject: [PATCH] Removing unecessary early stopping calls (#1863) * Removing unecessary early stopping calls * Update CHANGELOG.md Co-authored-by: Mateusz Pieniak Co-authored-by: William Falcon --- CHANGELOG.md | 2 ++ pytorch_lightning/trainer/training_loop.py | 6 ------ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b6280a1beeab6..6445988f1ed26 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,6 +38,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Fixed user warning when apex was used together with learning rate schedulers ([#1873](https://github.com/PyTorchLightning/pytorch-lightning/pull/1873)) +- Fixed multiple calls of `EarlyStopping` callback ([#1751](https://github.com/PyTorchLightning/pytorch-lightning/issues/1751)) + - Fixed an issue with `Trainer.from_argparse_args` when passing in unknown Trainer args ([#1932](https://github.com/PyTorchLightning/pytorch-lightning/pull/1932)) - Fix bug related to logger not being reset correctly for model after tuner algorithms ([#1933](https://github.com/PyTorchLightning/pytorch-lightning/pull/1933)) diff --git a/pytorch_lightning/trainer/training_loop.py b/pytorch_lightning/trainer/training_loop.py index 55c63679ae9f6..72fb77065f5ab 100644 --- a/pytorch_lightning/trainer/training_loop.py +++ b/pytorch_lightning/trainer/training_loop.py @@ -452,7 +452,6 @@ def run_training_epoch(self): if self.fast_dev_run or should_check_val: self.run_evaluation(test_mode=self.testing) self.call_checkpoint_callback() - self.call_early_stop_callback() # when logs should be saved should_save_log = (batch_idx + 1) % self.log_save_interval == 0 or early_stop_epoch @@ -498,7 +497,6 @@ def run_training_epoch(self): # when no val loop is present or fast-dev-run still need to call checkpoints if not self.is_overridden('validation_step') and not (self.fast_dev_run or should_check_val): self.call_checkpoint_callback() - self.call_early_stop_callback() # Epoch end events with self.profiler.profile('on_epoch_end'): @@ -791,10 +789,6 @@ def call_checkpoint_callback(self): if self.checkpoint_callback is not None: self.checkpoint_callback.on_validation_end(self, self.get_model()) - def call_early_stop_callback(self): - if self.early_stop_callback: - self.early_stop_callback.on_epoch_end(self, self.get_model()) - def _with_is_last(iterable): """Pass through values from the given iterable with an added boolean indicating if this is the last item.