Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wait_for_ready timeout errors #443

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Improve wait_for_ready timeout errors #443

merged 1 commit into from
Jun 19, 2024

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Jun 17, 2024

  • Timeouts now return human readable message instead of an error for timeout
    • Any other errors will be propagated as usual
  • Use wait_until instead of until_all()
  • Lower default timeout from 90sec to 60sec
    • Everything passed on my machine, we can see if it works (or I can delete it based on review)

@pehala pehala requested a review from azgabur June 17, 2024 12:18
trepel
trepel reviewed Jun 18, 2024
View reviewed changes
testsuite/gateway/gateway_api/gateway.py Show resolved Hide resolved
testsuite/policy/__init__.py Show resolved Hide resolved
testsuite/policy/authorization/auth_config.py Show resolved Hide resolved
testsuite/policy/tls_policy.py Show resolved Hide resolved
@trepel trepel mentioned this pull request Jun 18, 2024
Merged
@trepel trepel self-requested a review June 19, 2024 10:24
trepel
trepel previously approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is good to go. I ran some tests and they passed.

averevki
averevki previously approved these changes Jun 19, 2024
View reviewed changes
@pehala
Use wait_until instead of until_all()
b33ef5a 
- Timeout wont throw exception, but just returns false
@pehala pehala dismissed stale reviews from averevki and trepel via b33ef5a June 19, 2024 11:34
@pehala pehala requested review from averevki and trepel June 19, 2024 11:35
@pehala
Copy link
Contributor Author

pehala commented Jun 19, 2024

Rebased

@pehala pehala merged commit 12023ab into Kuadrant:main Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averevki averevki averevki approved these changes

@azgabur azgabur Awaiting requested review from azgabur

@trepel trepel Awaiting requested review from trepel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pehala @trepel @averevki