Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGC support for GWAPI v1 #630

Closed
5 tasks done
maleck13 opened this issue Oct 19, 2023 · 3 comments
Closed
5 tasks done

MGC support for GWAPI v1 #630

maleck13 opened this issue Oct 19, 2023 · 3 comments
Assignees
Labels
Milestone

Comments

@maleck13
Copy link
Contributor

maleck13 commented Oct 19, 2023

What

V1 of GWAPI is approaching we need to start testing with the new resources. https://github.com/kubernetes-sigs/gateway-api/releases/tag/v1.0.0-rc2

How

  • Update our GWAPI resources, install and create TLS and DNS policies
  • update our GWAPI dependencies in the Gateway controller
  • Move to released 1.20.0 of istio #665
  • update kuadrant-operator version which supports GWAPI v1 GA.
  • Update Gateway API Resources in the docs files to be V1
@laurafitzgerald laurafitzgerald self-assigned this Oct 20, 2023
@laurafitzgerald
Copy link
Contributor

@maleck13 maleck13 changed the title Test MGC with GWAPI v1 rc1 Test MGC with GWAPI v1 Oct 26, 2023
@laurafitzgerald
Copy link
Contributor

There's some discussion at https://kubernetes.slack.com/archives/C05J0D0V525/p1698851598969379 about an issue I faced due to rules being too costly for httproutes when it comes to parentRef.

kuadrant-operator have logged it here GEP: Add Name to HTTPRouteRule and HTTPRouteMatch · Issue #995 · kubernetes-sigs/gateway-api

And have a solution on their side Kuadrant/kuadrant-operator@56a9a34

It's blocking us from running our integration tests because the environment fails on CRD creation producing the following error

unable to install CRDs onto control plane: unable to create CRD instances: unable to create CRD \"httproutes.gateway.networking.k8s.io\": CustomResourceDefinition.apiextensions.k8s.io \"httproutes.gateway.networking.k8s.io\" is invalid: [spec.versions[0].schema.openAPIV3Schema.properties[spec].properties[parentRefs].x-kubernetes-validations[0].rule: Forbidden: estimated rule cost exceeds budget by factor of more than 100x (try simplifying the rule, or adding maxItems, maxProperties, and maxLength where arrays, maps, and strings are declared), spec.versions[0].schema.openAPIV3Schema.properties[spec].properties[parentRefs].x-kubernetes-validations[0].rule: Forbidden: contributed to estimated rule cost total exceeding cost limit for entire OpenAPIv3 schema, spec.versions[0].schema.openAPIV3Schema: Forbidden: x-kubernetes-validations estimated rule cost total for entire OpenAPIv3 schema exceeds budget by factor of more than 100x (try simplifying the rule, or adding maxItems, maxProperties, and maxLength where arrays, maps, and strings are declared)]

@laurafitzgerald
Copy link
Contributor

laurafitzgerald commented Nov 1, 2023

For running through the walkthrough one issue is faced for the istio class gateway, which is that the Programmed status remains unknown.

This could be addressed by istio/istio@73e4596 which is being cherrypicked to release 1.20.0 of istio. We are currently running 1.17.0.

1.20.0-beta.0 is available https://hub.docker.com/r/istio/pilot/tags but we may have a short wait for 1.20.0 to be available.

Update the following https://github.com/search?q=repo%3AKuadrant%2Fmulticluster-gateway-controller%201.17.0&type=code to move to the new version once it's available.

@pmccarthy pmccarthy changed the title Test MGC with GWAPI v1 MGC support for GWAPI v1 Nov 7, 2023
@maleck13 maleck13 added this to the v0.2.0 milestone Nov 14, 2023
openshift-merge-bot bot added a commit that referenced this issue Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants