Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] update integration tests #882

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] update integration tests #882

wants to merge 1 commit into from

Conversation

maksymvavilov
Copy link
Contributor

@maksymvavilov maksymvavilov commented Sep 27, 2024

Since we are no longer generating endpoints here in this PR I am:

  1. Removing validation of the endpoints (checking only for their presence)
  2. Merging two test files reducing total amount of tests run against the dnspolicy controller

It is a follow up on the #799

Signed-off-by: Maskym Vavilov <mvavilov@redhat.com>
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (ece13e8) to head (e451f1b).
Report is 193 commits behind head on main.

Files with missing lines Patch % Lines
controllers/dnspolicy_dnsrecords.go 84.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
+ Coverage   80.20%   81.01%   +0.80%     
==========================================
  Files          64       89      +25     
  Lines        4492     6879    +2387     
==========================================
+ Hits         3603     5573    +1970     
- Misses        600      888     +288     
- Partials      289      418     +129     
Flag Coverage Δ
bare-k8s-integration 6.84% <0.00%> (?)
controllers-integration 73.01% <88.23%> (?)
envoygateway-integration 49.49% <0.00%> (?)
gatewayapi-integration 12.59% <0.00%> (?)
integration ?
istio-integration 53.39% <0.00%> (?)
unit 28.46% <0.00%> (-1.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 84.61% <100.00%> (+13.18%) ⬆️
api/v1beta2 (u) 81.25% <75.17%> (-10.18%) ⬇️
pkg/common (u) 79.66% <ø> (-9.17%) ⬇️
pkg/istio (u) 70.95% <ø> (-2.96%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 84.26% <ø> (+4.81%) ⬆️
controllers (i) 82.46% <80.83%> (+5.66%) ⬆️
Files with missing lines Coverage Δ
controllers/dns_helper.go 92.30% <100.00%> (+8.32%) ⬆️
controllers/dnspolicy_dnsrecords.go 64.22% <84.00%> (-1.47%) ⬇️

... and 39 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant