Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ratelimitpolicy v1beta3 #875

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

ratelimitpolicy v1beta3 #875

wants to merge 5 commits into from

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Sep 25, 2024

No description provided.

Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
@eguzki eguzki linked an issue Sep 25, 2024 that may be closed by this pull request
@eguzki eguzki added kind/enhancement New feature or request size/medium area/api Changes user facing APIs labels Sep 25, 2024
@eguzki eguzki self-assigned this Sep 25, 2024
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 83.50515% with 16 lines in your changes missing coverage. Please review.

Project coverage is 78.74%. Comparing base (ece13e8) to head (0fe564a).
Report is 190 commits behind head on main.

Files with missing lines Patch % Lines
api/v1beta3/topology.go 0.00% 13 Missing ⚠️
controllers/state_of_the_world.go 0.00% 2 Missing ⚠️
controllers/httprouteparentrefs_eventmapper.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   80.20%   78.74%   -1.47%     
==========================================
  Files          64       92      +28     
  Lines        4492     7051    +2559     
==========================================
+ Hits         3603     5552    +1949     
- Misses        600     1091     +491     
- Partials      289      408     +119     
Flag Coverage Δ
bare-k8s-integration 5.12% <1.03%> (?)
controllers-integration 70.85% <78.35%> (?)
envoygateway-integration 46.49% <56.70%> (?)
gatewayapi-integration 10.77% <6.18%> (?)
integration ?
istio-integration 50.46% <77.31%> (?)
unit 27.74% <37.50%> (-2.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 38.46% <0.00%> (-32.97%) ⬇️
api/v1beta2 (u) 76.19% <70.83%> (-15.24%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 70.95% <ø> (-2.96%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 84.26% <ø> (+4.81%) ⬆️
controllers (i) 80.62% <82.75%> (+3.81%) ⬆️
Files with missing lines Coverage Δ
api/v1beta2/topology.go 0.00% <ø> (ø)
api/v1beta3/ratelimitpolicy_types.go 76.19% <ø> (ø)
api/v1beta3/route_selectors.go 100.00% <100.00%> (ø)
controllers/envoygateway_wasm_controller.go 82.30% <100.00%> (ø)
...ollers/limitador_cluster_envoyfilter_controller.go 73.03% <100.00%> (-8.79%) ⬇️
...s/limitador_status_to_rlp_gateway_event_handler.go 81.81% <100.00%> (ø)
...llers/rate_limiting_istio_wasmplugin_controller.go 70.87% <100.00%> (ø)
controllers/ratelimitpolicy_controller.go 81.55% <100.00%> (+7.55%) ⬆️
...lers/ratelimitpolicy_enforced_status_controller.go 86.18% <100.00%> (ø)
controllers/ratelimitpolicy_limits.go 81.35% <100.00%> (-0.91%) ⬇️
... and 10 more

... and 37 files with indirect coverage changes

Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes user facing APIs kind/enhancement New feature or request size/medium
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

RateLimitPolicy v1beta3
1 participant