Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog default channel #872

Closed
wants to merge 2 commits into from
Closed

Catalog default channel #872

wants to merge 2 commits into from

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Sep 24, 2024

No description provided.

doc/development.md: channels doc on custom bundle section

Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (ece13e8) to head (421e7e1).
Report is 192 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ece13e8) and HEAD (421e7e1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ece13e8) HEAD (421e7e1)
integration 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #872       +/-   ##
===========================================
- Coverage   80.20%   68.80%   -11.41%     
===========================================
  Files          64       91       +27     
  Lines        4492     7046     +2554     
===========================================
+ Hits         3603     4848     +1245     
- Misses        600     1794     +1194     
- Partials      289      404      +115     
Flag Coverage Δ
bare-k8s-integration 5.11% <ø> (?)
envoygateway-integration 46.65% <ø> (?)
gatewayapi-integration 10.75% <ø> (?)
integration ?
istio-integration 50.52% <ø> (?)
unit 27.75% <ø> (-2.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 38.46% <0.00%> (-32.97%) ⬇️
api/v1beta2 (u) 73.21% <62.41%> (-18.22%) ⬇️
pkg/common (u) 79.66% <ø> (-9.17%) ⬇️
pkg/istio (u) 70.95% <ø> (-2.96%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 84.26% <ø> (+4.81%) ⬆️
controllers (i) 66.43% <70.08%> (-10.37%) ⬇️

see 46 files with indirect coverage changes

@eguzki
Copy link
Contributor Author

eguzki commented Sep 27, 2024

closing in favor of #880

@eguzki eguzki closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant