Delete dns records when listener hostname changes #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymvavilov
approved these changes
Sep 5, 2024
mikenairn
force-pushed
the
recreate_dnsrecord_on_hostname_updates
branch
from
97761a8
to
7a61a29
Compare
I'm not really sure why it would change, but that said there is no harm in testing it. Test updated now to ensure that other listeners DNSRecords are not modified due to updates to another listener, and also that the wildcard listener DNSRecord can be updated in the same way. |
The DNSRecord resource does not handle changes made to the `rootHost` which can cause things to be left around in the provider if it is modified after intial record creation. This change modifies the logic detecting if existing records should be removed to take into account possible hostname changes, removing any that no longer match (qw.listener.hostname != record.spec.rootHost). Signed-off-by: Michael Nairn <mnairn@redhat.com>
mikenairn
force-pushed
the
recreate_dnsrecord_on_hostname_updates
branch
from
7a61a29
to
aadc472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #794
The DNSRecord resource does not handle changes made to the
rootHostwhich can cause things to be left around in the provider if it's modified after initial record creation. This change modifies the logic detecting if existing records should be removed to take into account possible hostname changes, removing any that no longer match (qw.listener.hostname != record.spec.rootHost).related: Kuadrant/dns-operator#219