Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gateway API to v1.1 #780

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Update Gateway API to v1.1 #780

merged 2 commits into from
Jul 26, 2024

Conversation

adam-cattermole
Copy link
Member

@adam-cattermole adam-cattermole commented Jul 24, 2024

Changes

  • Gateway API v1.1
  • Use of LocalPolicyTargetReference
  • (update to the pinned sail-operator go module due to conflict)

Resolves #732, resolves #705

@adam-cattermole adam-cattermole self-assigned this Jul 24, 2024
@adam-cattermole adam-cattermole changed the title Update gatewayapi to v1.1 Update Gateway API to v1.1 Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.28%. Comparing base (ece13e8) to head (72c5c53).
Report is 147 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
+ Coverage   80.20%   82.28%   +2.07%     
==========================================
  Files          64       77      +13     
  Lines        4492     6126    +1634     
==========================================
+ Hits         3603     5041    +1438     
- Misses        600      721     +121     
- Partials      289      364      +75     
Flag Coverage Δ
bare-k8s-integration 4.47% <0.00%> (?)
controllers-integration 71.85% <100.00%> (?)
gatewayapi-integration 10.70% <0.00%> (?)
integration ?
istio-integration 56.08% <58.62%> (?)
unit 31.84% <30.00%> (+1.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 90.39% <87.64%> (-1.04%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 72.50% <ø> (-1.41%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 83.64% <ø> (+4.19%) ⬆️
controllers (i) 81.93% <83.39%> (+5.13%) ⬆️
Files Coverage Δ
api/v1alpha1/dnspolicy_types.go 76.47% <100.00%> (-5.35%) ⬇️
api/v1alpha1/tlspolicy_types.go 89.09% <100.00%> (+14.73%) ⬆️
api/v1beta2/authpolicy_types.go 92.68% <100.00%> (+2.20%) ⬆️
api/v1beta2/ratelimitpolicy_types.go 84.93% <100.00%> (-4.16%) ⬇️
controllers/authpolicy_controller.go 83.82% <ø> (+3.12%) ⬆️
...ontrollers/authpolicy_istio_authorizationpolicy.go 85.92% <100.00%> (-1.40%) ⬇️
controllers/dnspolicy_controller.go 76.54% <ø> (-6.94%) ⬇️
controllers/httprouteparentrefs_eventmapper.go 58.33% <100.00%> (+4.48%) ⬆️
controllers/ratelimitpolicy_controller.go 80.39% <ø> (+6.39%) ⬆️
controllers/target_status_controller.go 88.66% <100.00%> (ø)
... and 9 more

... and 29 files with indirect coverage changes

@adam-cattermole adam-cattermole linked an issue Jul 24, 2024 that may be closed by this pull request
@adam-cattermole adam-cattermole marked this pull request as ready for review July 24, 2024 12:04
@adam-cattermole adam-cattermole requested a review from a team as a code owner July 24, 2024 12:04
Copy link
Collaborator

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me

@maleck13
Copy link
Collaborator

/lgtm

@maleck13
Copy link
Collaborator

@adam-cattermole I think it would be worth checking the quick start docs and docs repo also to see do we refer to installing a particular version of Gateway API

Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me 👍

Copy link
Collaborator

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after your explanation regarding LocalPolicyTargetReference that is the reason for removing the namespace tests. You'll need to rebase with main tho. 🥧

@eguzki eguzki added the kind/enhancement New feature or request label Jul 25, 2024
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
@@ -1,39 +1,39 @@
module github.com/kuadrant/kuadrant-operator

go 1.22
go 1.22.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was intended?

Copy link
Member Author

@adam-cattermole adam-cattermole Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as of 1.22 the toolchain directive is added if the go version is not specific. I.e. if I run go mod tidy with go version 1.22.5 it updates the go.mod to the following:

go 1.22.0

toolchain go1.22.5

The only way to avoid is adding the full version afaict

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL this. Thanks.

@adam-cattermole adam-cattermole merged commit ef9c809 into main Jul 26, 2024
27 checks passed
@adam-cattermole adam-cattermole deleted the gwapi-v1.1 branch July 26, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move to 1.1 of Gateway API Switch to using LocalPolicyTargetReference struct instead
5 participants