fix flaky test: TestNewGatewayEventMapper #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
commented
Jul 23, 2024
| @@ -90,7 +91,11 @@ func TestNewGatewayEventMapper(t *testing.T) { | |||
| }, | |||
| } | |||
| requests := em.MapToPolicy(context.Background(), gateway, &kuadrantv1beta2.AuthPolicy{}) | |||
| expected := []reconcile.Request{{NamespacedName: types.NamespacedName{Namespace: "app-ns", Name: "policy-1"}}, {NamespacedName: types.NamespacedName{Namespace: "app-ns", Name: "policy-2"}}} | |||
| assert.DeepEqual(subT, expected, requests) | |||
| assert.Assert(subT, utils.Index(requests, func(r reconcile.Request) bool { | |||
There was a problem hiding this comment.
order does not matter and it was enforced by the test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
==========================================
+ Coverage 80.20% 82.75% +2.54%
==========================================
Files 64 77 +13
Lines 4492 6101 +1609
==========================================
+ Hits 3603 5049 +1446
- Misses 600 698 +98
- Partials 289 354 +65
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KevFan
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.