Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kind to v0.23.0 #725

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Update kind to v0.23.0 #725

merged 2 commits into from
Jul 4, 2024

Conversation

dlaw4608
Copy link
Contributor

@dlaw4608 dlaw4608 commented Jul 2, 2024

Update Kind to v0.23.0 and Node Image to v1.30.0

Description

This PR updates the Kind version used in the Makefile and GitHub workflows from v0.22.0 to v0.23.0. Additionally, the node image is updated to v1.30.0.

Changes Made

  • Updated Kind version to v0.23.0 in the Makefile.
  • Updated Kind version to v0.23.0 in GitHub workflows.
  • Updated the node image to v1.30.0.
  • Updated the development readme to reflect these changes.

@dlaw4608 dlaw4608 requested a review from a team as a code owner July 2, 2024 16:00
@maleck13
Copy link
Collaborator

maleck13 commented Jul 3, 2024

The commit log here is a bit strange. Maybe take the changes and add a single commit ?

Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update the version at the development README at https://github.com/Kuadrant/kuadrant-operator/blob/main/doc/development.md#development-guide also ?

And agreeing with @maleck13, the commit history will be nicer if you can rebase and put the changes into a single commit 👍

@KevFan KevFan added kind/enhancement New feature or request size/small dependencies Pull requests that update a dependency file labels Jul 3, 2024
@dlaw4608 dlaw4608 changed the title Update kind to v0.23.0 #720 Update kind to v0.23.0 Jul 3, 2024
@dlaw4608 dlaw4608 marked this pull request as draft July 3, 2024 11:44
@dlaw4608 dlaw4608 force-pushed the kind_update branch 3 times, most recently from df25f13 to 14ba63e Compare July 3, 2024 14:50
@dlaw4608 dlaw4608 mentioned this pull request Jul 3, 2024
@dlaw4608 dlaw4608 marked this pull request as ready for review July 3, 2024 15:38
Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@dlaw4608 dlaw4608 merged commit 9863d85 into Kuadrant:main Jul 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file kind/enhancement New feature or request size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants