Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refer to the DNS HealthCheckSpeck from dns-operator repo #723

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Refer to the DNS HealthCheckSpeck from dns-operator repo #723

merged 1 commit into from
Jul 24, 2024

Conversation

maksymvavilov
Copy link
Contributor

@maksymvavilov maksymvavilov commented Jun 28, 2024 •
edited
Loading

Stop redefining DNSRecord HealthCheckSpec from dns-operator repo.
Also, push to a fresher commit of the dns-operator so we have the latest CRD

@maksymvavilov maksymvavilov requested a review from a team as a code owner June 28, 2024 13:52
@maksymvavilov maksymvavilov linked an issue Jun 28, 2024 that may be closed by this pull request
Improve validations on DNSRecord spec fields Kuadrant/dns-operator#110
Closed
@maksymvavilov maksymvavilov changed the title refer to the DNSSpeck from dns-operator repo refer to the DNS Speck from dns-operator repo Jun 28, 2024
@maksymvavilov maksymvavilov changed the title refer to the DNS Speck from dns-operator repo refer to the DNS HealthCheckSpeck from dns-operator repo Jun 28, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.56%. Comparing base (ece13e8) to head (32696d1).
Report is 143 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
+ Coverage   80.20%   82.56%   +2.35%     
==========================================
  Files          64       77      +13     
  Lines        4492     6144    +1652     
==========================================
+ Hits         3603     5073    +1470     
- Misses        600      710     +110     
- Partials      289      361      +72
Flag Coverage Δ
bare-k8s-integration 4.43% <0.00%> (?)
controllers-integration 72.12% <0.00%> (?)
gatewayapi-integration 10.61% <0.00%> (?)
integration ?
istio-integration 55.96% <0.00%> (?)
unit 33.72% <0.00%> (+3.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 90.81% <87.20%> (-0.62%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 73.88% <ø> (-0.03%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 84.27% <ø> (+4.81%) ⬆️
controllers (i) 82.22% <83.80%> (+5.42%) ⬆️
Files Coverage Δ
controllers/dnspolicy_dnsrecords.go 63.06% <0.00%> (-2.63%) ⬇️
api/v1alpha1/dnspolicy_types.go 75.82% <0.00%> (-6.00%) ⬇️

... and 37 files with indirect coverage changes

philbrookes
philbrookes reviewed Jun 28, 2024
View reviewed changes
bundle/manifests/kuadrant.io_dnspolicies.yaml
the listeners assigned to the target gateway
properties:
endpoint:
description: |-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't seem great to have lost the field descriptions, can they be re-added to the Spec in the DNS Operator to keep them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added those to the DNS Operator bu we will see them here only after the dns-operator PR gets merged

Copy link
Contributor Author

@maksymvavilov maksymvavilov Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philbrookes now should be fine

@maksymvavilov maksymvavilov mentioned this pull request Jun 28, 2024
Merged
@maksymvavilov maksymvavilov changed the title refer to the DNS HealthCheckSpeck from dns-operator repo [WIP] refer to the DNS HealthCheckSpeck from dns-operator repo Jun 28, 2024
@maksymvavilov maksymvavilov changed the title [WIP] refer to the DNS HealthCheckSpeck from dns-operator repo Refer to the DNS HealthCheckSpeck from dns-operator repo Jun 28, 2024
@maksymvavilov
Copy link
Contributor Author

image
codecov is being silly The patch is fine

mikenairn
mikenairn approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@mikenairn mikenairn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, maybe @philbrookes could take a quick look since its health check related.

@maksymvavilov
refer to the DNSSpeck from dns-operator repo
32696d1 
Signed-off-by: Maskym Vavilov <mvavilov@redhat.com>
@maksymvavilov maksymvavilov merged commit 06b9d8b into main Jul 24, 2024
26 of 27 checks passed
@maksymvavilov maksymvavilov deleted the gh-110 branch July 24, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikenairn mikenairn mikenairn approved these changes

@philbrookes philbrookes philbrookes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve validations on DNSRecord spec fields
3 participants
@maksymvavilov @mikenairn @philbrookes