refactor: parrallel tests #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevFan
force-pushed
the
parrallel-tests-2
branch
8 times, most recently
from
31176e7
to
88e5329
Compare
KevFan
added
kind/enhancement
…ndAcceptedStatus tests
KevFan
force-pushed
the
parrallel-tests-2
branch
from
88e5329
to
c9857f2
Compare
|
great job 🏅 other than few comments about small issues, this LGTM. |
|
all integration tests working locally as verification step |
eguzki
reviewed
Jun 12, 2024
| p1Status := meta.IsStatusConditionTrue(a[i].GetStatus().GetConditions(), string(gatewayapiv1alpha2.PolicyConditionAccepted)) | ||
| p2Status := meta.IsStatusConditionTrue(a[j].GetStatus().GetConditions(), string(gatewayapiv1alpha2.PolicyConditionAccepted)) | ||
| if p1Status != p2Status { | ||
| return p1Status |
There was a problem hiding this comment.
nice! I would also do the same.
…one + timeouts Since Kuadrant/dns-operator#156 was merged, dnsrecords with finizalers are left behind as ManagedZone was deleted causing the test namespaces to never be fully deleted. Additionally use SpecContext and add timeouts for context so problematic tests terminate earlier
KevFan
force-pushed
the
parrallel-tests-2
branch
from
bc8d6cf
to
c70b5e1
Compare
dlaw4608
pushed a commit
to dlaw4608/kuadrant-operator
that referenced
this pull request
Jun 17, 2024
* make: concurrent tests flags * refactor: concurrent bare k8s tests * refactor: concurrent gateway api k8s tests * refactor: concurrent istio tests * refactor: test packages for base concurrent integration tests * refactor: do not wait kuadrant to be ready for integration tests * fix: sort policy by kind, creation, condition for target status * refactor: separate out serial tests that can affect other tests * harden: RLP integration test updates & sort by PolicyByTargetRefKindAndAcceptedStatus tests * refactor: rename ratelimit test package to ratelimitpolicy * fix: wait for dnsrecords to finish deleting before deleting managed zone + timeouts Since Kuadrant/dns-operator#156 was merged, dnsrecords with finizalers are left behind as ManagedZone was deleted causing the test namespaces to never be fully deleted. Additionally use SpecContext and add timeouts for context so problematic tests terminate earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run integration tests concurrently where possible. Tests that cannot / may affect the stablility of other tests are kept running serially.
Independant test suites are run serially, but each test suites runs their tests in parallel where possible
The following changes were introduced generally:
tests/common/xfromcontrollers, each now having their own test suitesBeforeSuite/AfterSuite(e.g. some require a Kuadrant installation, others do not)controllers/ratelimit). This is doable if we can live with duplicate test suite codeReadyin the CREventuallyblockTests now complete ~6.5 - 8 mins (previously took ~26 mins)
Verification
Passing workflow should be sufficient.
But if you want to try out running the integration tests:
make local-env-setup test-integration