Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy example alerts during quickstart #644

Merged
merged 1 commit into from
May 14, 2024
Merged

Deploy example alerts during quickstart #644

merged 1 commit into from
May 14, 2024

Conversation

david-martin
Copy link
Contributor

To round out #440 and #441 , this change deploys the example alert rules during the quickstart setup.

To verify, run the quickstart-setup script (referencing this branch for now until back on main)

image

image

@david-martin david-martin requested a review from a team as a code owner May 13, 2024 14:44
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (ece13e8) to head (9782bc3).
Report is 91 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   80.20%   82.56%   +2.35%     
==========================================
  Files          64       72       +8     
  Lines        4492     5415     +923     
==========================================
+ Hits         3603     4471     +868     
- Misses        600      638      +38     
- Partials      289      306      +17     
Flag Coverage Δ
integration 74.01% <ø> (+2.73%) ⬆️
unit 33.73% <ø> (+3.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 93.58% <100.00%> (+2.16%) ⬆️
pkg/common (u) 83.78% <ø> (-5.05%) ⬇️
pkg/istio (u) 75.86% <ø> (+1.94%) ⬆️
pkg/log (u) 100.00% <ø> (+5.26%) ⬆️
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 79.84% <ø> (+0.39%) ⬆️
controllers (i) 80.77% <82.62%> (+3.97%) ⬆️

see 32 files with indirect coverage changes

hack/quickstart-setup.sh Outdated Show resolved Hide resolved
Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally, seems to work fine

@R-Lawton
Copy link
Contributor

lgtm

@R-Lawton R-Lawton merged commit e6bfc0c into main May 14, 2024
22 checks passed
@eguzki eguzki deleted the deploy-alerts branch June 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants