Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc format #622

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Doc format #622

wants to merge 3 commits into from

Conversation

maleck13
Copy link
Collaborator

@maleck13 maleck13 commented May 7, 2024

some missing code quotes

@maleck13 maleck13 requested a review from a team as a code owner May 7, 2024 07:38
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (ece13e8) to head (0a38155).
Report is 72 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
+ Coverage   80.20%   82.21%   +2.00%     
==========================================
  Files          64       71       +7     
  Lines        4492     5280     +788     
==========================================
+ Hits         3603     4341     +738     
- Misses        600      635      +35     
- Partials      289      304      +15     
Flag Coverage Δ
integration 73.47% <ø> (+2.19%) ⬆️
unit 32.74% <ø> (+2.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 93.58% <100.00%> (+2.16%) ⬆️
pkg/common (u) 83.78% <ø> (-5.05%) ⬇️
pkg/istio (u) 75.14% <ø> (+1.23%) ⬆️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 79.84% <ø> (+0.39%) ⬆️
controllers (i) 80.06% <83.73%> (+3.26%) ⬆️

see 25 files with indirect coverage changes

Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I can push this to 0.7.0 docs after (a bit manual right now)

@eguzki
Copy link
Contributor

eguzki commented Sep 2, 2024

@maleck13 do you still want to push for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants