Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test speed up #581

Closed
wants to merge 2 commits into from
Closed

feat: test speed up #581

wants to merge 2 commits into from

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Apr 25, 2024

Integration tests are failing by timeout at 1hour mark due to this is the default suite timeout for ginkgo

Introducing some changes to speed up general running of the tests to decrease test run time rather than increasing suite timeout:

toystore application is not used thoughout the tests and deleting a ns with it deployed takes a lot longer than without
@KevFan KevFan marked this pull request as ready for review April 26, 2024 07:31
@KevFan KevFan requested a review from a team as a code owner April 26, 2024 07:31
@mikenairn
Copy link
Member

mikenairn commented Apr 26, 2024

Anything that speeds the tests up and makes them less flaky sounds good to me. I will let others more familiar with the Auth and RLP tests that are changing approve however.

I have a test related PR here to make it possible to run the DNS and TLS policy tests in parallel. This makes a significant difference in how long the test suite takes. We should probably try and get to a point where the vast majority, if not all, the test suite can be run in parallel and enable it on the ci job. Using Ordered prevents those tests from being run in parallel, but if it makes it quicker in the mean time then lets go with it.

@KevFan
Copy link
Contributor Author

KevFan commented Apr 26, 2024

Superseded by #565 as its seem to be running stably now which contains these changes

@KevFan KevFan closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants