Update dnspolicy crd validations #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
force-pushed
the
fix_dnspolicy_crd_validations
branch
from
fdf7805
to
4d59725
Compare
mikenairn
commented
Apr 25, 2024
The validations to ensure required fields were marked as required were incorrect. Any fields that are not explicitly marked with `+optional` and do not have `omitempty` are considered required.
mikenairn
force-pushed
the
fix_dnspolicy_crd_validations
branch
from
4d59725
to
c29d990
Compare
mikenairn
commented
Apr 25, 2024
| @@ -208,7 +208,6 @@ func (dh *dnsHelper) getLoadBalancedEndpoints(mcgTarget *multicluster.GatewayTar | |||
| } | |||
|
|
|||
| var endpoint *externaldns.Endpoint | |||
| var defaultEndpoint *externaldns.Endpoint | |||
There was a problem hiding this comment.
@makslion fyi, i removed this as it's not needed any longer. Also added some more relevant comments below.
mikenairn
force-pushed
the
fix_dnspolicy_crd_validations
branch
from
c29d990
to
0c0a4f0
Compare
Update the CRD validations to make the "loadBalancing" field required if
the routingStrategy is "loadbalanced" and make the "defaultWeight" and
"defaultGeo" fields mandatory within the "loadBalancing" section.
Minimum valid specs are now:
Simple:
```
spec:
targetRef:
name: prod-web
group: gateway.networking.k8s.io
kind: Gateway
routingStrategy: simple
```
LoadBalanced:
```
spec:
targetRef:
name: prod-web
group: gateway.networking.k8s.io
kind: Gateway
routingStrategy: loadbalanced
loadBalancing:
geo:
defaultGeo: foo
weighted:
defaultWeight: 100
```
mikenairn
force-pushed
the
fix_dnspolicy_crd_validations
branch
from
0c0a4f0
to
08c7cca
Compare
maleck13
approved these changes
Apr 26, 2024
|
/lgtm |
|
Test are still broken for other reasons, verified the dns tests locally: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #554
fix: DNSPolicy CRD required validations
The validations to ensure required fields were marked as required were incorrect.
Any fields that are not explicitly marked with
+optionaland do not haveomitemptyare considered required.Update loadbalanced routingStrategy CRD validation
Update the CRD validations to make the "loadBalancing" field required if the routingStrategy is "loadbalanced" and make the "defaultWeight" and "defaultGeo" fields mandatory within the "loadBalancing" section.
Minimum valid specs are now:
Simple:
LoadBalanced: