Fixing tests #55
Merged
Fixing tests #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also required in some tests
eguzki
reviewed
Oct 21, 2022
eguzki
reviewed
Oct 21, 2022
didierofrivia
force-pushed
the
fixing-merged-test
branch
from
3040fb8
to
e6a6b43
Compare
eguzki
approved these changes
Oct 24, 2022
|
tests failing.. should be passing |
didierofrivia
force-pushed
the
fixing-merged-test
branch
from
e6a6b43
to
cfc8a96
Compare
* Updated kind config yaml
didierofrivia
force-pushed
the
fixing-merged-test
branch
from
cfc8a96
to
6fce421
Compare
* Before it asserts the created resources * Kuadrant CR will trigger the deploy of required services
* Fixing authpolicy tests as a bonus
* It's required by dependencies deployment
* Some dependencies get config from ENV (namepace, name, etc)
eguzki
reviewed
Oct 27, 2022
| BeforeEach(CreateNamespaceCallback(&testNamespace)) | ||
| beforeEachCallback := func() { | ||
| CreateNamespace(&testNamespace) | ||
| ApplyKuadrantCR(testNamespace) |
There was a problem hiding this comment.
should it be kuadrantDefaultNamespace?
There was a problem hiding this comment.
in this test is not particularly needed, since the assertions made and Authorino OP and service are not setup via ENVs.
eguzki
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some tests that were not executed before and were failing after.
The AuthPolicyController test are marked as pending, because the reconciling cycle is failing as well. This will be addressed in a following PR.It's fixed in this PR finally.Note: Tests should pass when merged.