-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-545 restrict default geo to local #549
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
===========================================
- Coverage 80.20% 31.97% -48.24%
===========================================
Files 64 65 +1
Lines 4492 4910 +418
===========================================
- Hits 3603 1570 -2033
- Misses 600 3247 +2647
+ Partials 289 93 -196
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eb6acdf
to
b8d0863
Compare
7ad8e81
to
6032133
Compare
053dd92
to
2f217c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, and along with #578, should resolve the default geo issue.
Unfortunately the tests are failing, but looks like an unrelated flake.
Lets get this merged first and I'll deal with updating mine.
Build images job failing for odd reason, created an issue for it #580 |
Verified locally that the DNSPolicy tests are still working:
Don't like merging with failing tests but needs must. |
Prevent creation of the default endpoint if we are using the
LoadBalanced
strategy and thelb-attribute-geo-code
label on a gateway does not match the default geo in the policy spec