Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics server in dev cluster #516

Merged
merged 1 commit into from
Apr 3, 2024
Merged

metrics server in dev cluster #516

merged 1 commit into from
Apr 3, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Apr 3, 2024

What

Deploy metrics server in kind cluster (development cluster)

The metrics server enables kubectl top pod

❯ kubectl top pod -A
NAMESPACE            NAME                                                    CPU(cores)   MEMORY(bytes)   
cert-manager         cert-manager-7bd4d4cdff-6l4fl                           1m           22Mi            

The metrics server also enables k9s in pods tab to show few more columns with cpu, mem usage

Screenshot from 2024-04-03 14-06-48

@eguzki eguzki requested a review from a team as a code owner April 3, 2024 09:56
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #516 (5adf3fd) into main (ece13e8) will increase coverage by 0.14%.
Report is 12 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
+ Coverage   80.20%   80.35%   +0.14%     
==========================================
  Files          64       64              
  Lines        4492     4516      +24     
==========================================
+ Hits         3603     3629      +26     
+ Misses        600      596       -4     
- Partials      289      291       +2     
Flag Coverage Δ
integration 71.39% <ø> (+0.10%) ⬆️
unit 29.88% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 91.42% <ø> (ø)
pkg/common (u) 88.82% <ø> (ø)
pkg/istio (u) 73.91% <ø> (ø)
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) 64.04% <ø> (ø)
pkg/rlptools (u) 79.45% <ø> (ø)
controllers (i) 77.07% <75.00%> (+0.27%) ⬆️

see 10 files with indirect coverage changes

Copy link
Contributor

@david-martin david-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ kubectl get pods --namespace kube-system -l k8s-app=metrics-server
NAME                              READY   STATUS    RESTARTS   AGE
metrics-server-6b4d6cb49f-927nb   1/1     Running   0          3m4s
$ kubectl get --raw "/apis/metrics.k8s.io/v1beta1/nodes" | jq .
{
  "kind": "NodeMetricsList",
  "apiVersion": "metrics.k8s.io/v1beta1",
  "metadata": {},
  "items": [
    {
      "metadata": {
        "name": "kuadrant-local-control-plane",
        "creationTimestamp": "2024-04-03T11:23:45Z",
        "labels": {
          "beta.kubernetes.io/arch": "arm64",
          "beta.kubernetes.io/os": "linux",
          "kubernetes.io/arch": "arm64",
          "kubernetes.io/hostname": "kuadrant-local-control-plane",
          "kubernetes.io/os": "linux",
          "node-role.kubernetes.io/control-plane": "",
          "node.kubernetes.io/exclude-from-external-load-balancers": ""
        }
      },
      "timestamp": "2024-04-03T11:23:31Z",
      "window": "10.043s",
      "usage": {
        "cpu": "64628397n",
        "memory": "1243248Ki"
      }
    }
  ]
}

@david-martin
Copy link
Contributor

/lgtm
/approve

@david-martin
Copy link
Contributor

(I've switched over to podman on macos, so needed these pending changes to verify this pr #517)

@eguzki eguzki merged commit 4a31717 into main Apr 3, 2024
22 checks passed
@eguzki eguzki deleted the add-metric-server branch April 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants