Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nightly job #427

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix Nightly job #427

merged 1 commit into from
Feb 19, 2024

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Feb 19, 2024

  • Move shell expression into separate job

@pehala pehala requested a review from a team as a code owner February 19, 2024 07:53
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #427 (15203b3) into main (c0fa2a2) will decrease coverage by 0.26%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   81.17%   80.92%   -0.26%     
==========================================
  Files          40       40              
  Lines        3140     3140              
==========================================
- Hits         2549     2541       -8     
- Misses        396      404       +8     
  Partials      195      195              
Flag Coverage Δ
integration 69.17% <ø> (-0.74%) ⬇️
unit 35.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 90.90% <ø> (ø)
pkg/common (u) 89.23% <ø> (ø)
pkg/istio (u) 73.91% <ø> (-1.25%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) 79.33% <ø> (-0.83%) ⬇️
pkg/rlptools (u) 79.45% <ø> (ø)
controllers (i) 77.39% <ø> (-0.26%) ⬇️

see 5 files with indirect coverage changes

Copy link
Collaborator

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍸

@pehala pehala merged commit 9c55415 into Kuadrant:main Feb 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants