-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance docker network ipaddresspool #418
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 66.41% 65.75% -0.67%
==========================================
Files 38 38
Lines 3901 3901
==========================================
- Hits 2591 2565 -26
- Misses 1125 1146 +21
- Partials 185 190 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍪
@mikenairn ready to review. Can you check it works for you as well? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried locally, all seems to be working as expected 👍
What
metallb is configured with the network address, or subnet, of the docker network defined by kind.
docker network inspect kind
looks likeCurrently, the script
utils/docker-network-ipaddresspool.sh
was parsing only the first item of theIPAM.Config
list. When IPv6 is also there, the order of the items is not assured. So it can also beThis PR enhances the script to read only IPv4 subnets.