Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metallb addresspool setup #417

Closed
wants to merge 1 commit into from

Conversation

mikenairn
Copy link
Member

Update the docker network ipaddresspool setup script to account for network configs that do not have the IPv4 address as the first element of the array.

@mikenairn mikenairn requested a review from a team as a code owner February 9, 2024 09:17
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Merging #417 (e2d6f33) into main (133645e) will decrease coverage by 0.42%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   66.26%   65.85%   -0.42%     
==========================================
  Files          38       38              
  Lines        3901     3901              
==========================================
- Hits         2585     2569      -16     
- Misses       1129     1143      +14     
- Partials      187      189       +2     
Flag Coverage Δ
integration 70.60% <ø> (-0.79%) ⬇️
unit 60.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 78.59% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.44% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.60% <ø> (-0.79%) ⬇️

see 4 files with indirect coverage changes

@mikenairn
Copy link
Member Author

@eguzki This works for me, and i also have IPv6 enabled, just happens to be ordered differently:

"EnableIPv6": true,                             
        "IPAM": {                                        
            "Driver": "default",                         
            "Options": {},                               
            "Config": [                                  
                {                                                    
                    "Subnet": "172.18.0.0/16",                       
                    "Gateway": "172.18.0.1"                                                                                                                                                                                                                                                                                   
                },                                                   
                {                                                                                                                                              
                    "Subnet": "fc00:f853:ccd:e793::/64",
                    "Gateway": "fc00:f853:ccd:e793::1"                                                                                                         
                }                                                                                                                                              
            ]                                                                                                                                                  
        },                  

Mine also has a Subnet and Gateway field though, so maybe check this actually works for you.

Update the docker network ipaddresspool setup script to account for
network configs that do not have the IPv4 address as the first element
of the array.
@eguzki
Copy link
Contributor

eguzki commented Feb 9, 2024

This is the fix I applied as a workaround #418

@mikenairn mikenairn closed this Feb 13, 2024
@mikenairn mikenairn deleted the fix_metallb_setup branch February 13, 2024 21:55
@mikenairn
Copy link
Member Author

Closed in favour of #418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants