Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm shim image from env var #41

Merged
merged 1 commit into from
Sep 15, 2022
Merged

wasm shim image from env var #41

merged 1 commit into from
Sep 15, 2022

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Sep 9, 2022

what

In order to pin the wasm shim image from the manifest bundle, the image needs to be exposed in the manifests and read from an env var by the controller

Additionally, the operator configures the kuadrant core controller (aka kuadrant-controller) with the WASM_FILTER_IMAGE env var.

verification steps

run dev env

make kind-create-kuadrant-cluster

Create kuadrant CR

k apply -f - <<EOF
---
apiVersion: kuadrant.kuadrant.io/v1beta1
kind: Kuadrant
metadata:
  name: kuadrant-sample
spec: {}
EOF

Check that the kuadrant core controller has the wasm shim image url specified in the deployment object

k get deployments kuadrant-controller-manager -o jsonpath='{.spec.template.spec.containers[].env}' | yq_pretty
- name: LIMITADOR_NAMESPACE
  value: default
- name: LIMITADOR_NAME
  value: limitador
- name: WASM_FILTER_IMAGE
  value: oci://quay.io/kuadrant/wasm-shim:latest

@eguzki eguzki requested review from didierofrivia and a team September 9, 2022 16:25
@eguzki eguzki added this to the v0.2.0 milestone Sep 9, 2022
@eguzki
Copy link
Contributor Author

eguzki commented Sep 9, 2022

the kuadrant controller manifest test is fixed here #42

@eguzki eguzki self-assigned this Sep 12, 2022
@eguzki
Copy link
Contributor Author

eguzki commented Sep 14, 2022

integration test fixed in #45

@eguzki eguzki merged commit 2b698a1 into main Sep 15, 2022
@eguzki eguzki deleted the wasm-shim-as-related-image branch September 15, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request size/small
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants