Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fixing some broken links #408

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jasonmadigan
Copy link
Member

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #408 (53b9fe8) into main (2c2d5dc) will decrease coverage by 0.98%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   66.59%   65.62%   -0.98%     
==========================================
  Files          38       38              
  Lines        3901     3901              
==========================================
- Hits         2598     2560      -38     
- Misses       1120     1151      +31     
- Partials      183      190       +7     
Flag Coverage Δ
integration 70.16% <ø> (-1.88%) ⬇️
unit 60.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 78.59% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.44% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.16% <ø> (-1.88%) ⬇️

see 5 files with indirect coverage changes

Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍬

@jasonmadigan jasonmadigan merged commit 45b81bb into Kuadrant:main Feb 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants