Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle #367

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix bundle #367

merged 1 commit into from
Dec 8, 2023

Conversation

alexsnaps
Copy link
Member

No description provided.

@alexsnaps alexsnaps requested a review from a team as a code owner December 8, 2023 14:11
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the same result when running make verify-bundle locally. Looks good to me assuming tests pass

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #367 (911af16) into main (6e985e3) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   65.36%   65.36%           
=======================================
  Files          35       35           
  Lines        3843     3843           
=======================================
  Hits         2512     2512           
  Misses       1133     1133           
  Partials      198      198           
Flag Coverage Δ
unit 59.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.21% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.58% <ø> (ø)

@alexsnaps alexsnaps merged commit 4957d5b into main Dec 8, 2023
22 checks passed
@alexsnaps alexsnaps deleted the fix_bundle branch December 8, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants