Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to new project and include PRs #366

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Add to new project and include PRs #366

merged 2 commits into from
Dec 8, 2023

Conversation

alexsnaps
Copy link
Member

No description provided.

@alexsnaps alexsnaps requested a review from a team as a code owner December 8, 2023 13:59
@@ -4,6 +4,11 @@ on:
issues:
types:
- opened
pull_request:
branches:
- main
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure whether we would want to include PRs targeting all branches... 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes... if we ever need to do work on a released branch or something... deleting!

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #366 (5953833) into main (4957d5b) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   65.23%   65.26%   +0.02%     
==========================================
  Files          35       35              
  Lines        3843     3843              
==========================================
+ Hits         2507     2508       +1     
+ Misses       1138     1136       -2     
- Partials      198      199       +1     
Flag Coverage Δ
integration 70.38% <ø> (+0.04%) ⬆️
unit 59.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.21% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.38% <ø> (+0.04%) ⬆️

see 5 files with indirect coverage changes

Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, changes look good and should alleviate all the manual interaction

@alexsnaps alexsnaps merged commit 13c75de into main Dec 8, 2023
22 checks passed
@alexsnaps alexsnaps deleted the gh_action branch December 8, 2023 14:58
@alexsnaps alexsnaps added this to the v0.6.0 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants