Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authconfig annotations reconciliation #359

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Dec 5, 2023

The authpolicy controller does not enforce any annotation, thus, it should not be part of the mutator

@eguzki eguzki requested a review from a team as a code owner December 5, 2023 14:57
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #359 (a52a6fe) into main (f17aadb) will increase coverage by 0.15%.
The diff coverage is 75.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   64.64%   64.80%   +0.15%     
==========================================
  Files          35       35              
  Lines        3804     3804              
==========================================
+ Hits         2459     2465       +6     
+ Misses       1147     1139       -8     
- Partials      198      200       +2     
Flag Coverage Δ
integration 69.63% <75.00%> (+0.29%) ⬆️
unit 59.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.21% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 69.63% <75.00%> (+0.29%) ⬆️
Files Coverage Δ
controllers/authpolicy_authconfig.go 66.31% <75.00%> (ø)

... and 5 files with indirect coverage changes

@alexsnaps alexsnaps added this to the v0.6.0 milestone Dec 5, 2023
@eguzki eguzki merged commit 62ff20d into main Dec 5, 2023
21 checks passed
@eguzki eguzki deleted the fix-authconfig-annotations-reconciliation branch December 5, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants