rlp e2e tests: fix sync issues #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 65.26% 64.10% -1.17%
==========================================
Files 35 35
Lines 3792 3794 +2
==========================================
- Hits 2475 2432 -43
- Misses 1132 1163 +31
- Partials 185 199 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
didierofrivia
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
So when we work on #87 we could stop relying on time based waiting assertions and check the status of the Wasmplugin. 🎖️
|
|
||
| // Unfortunately, WasmPlugin does not have status yet | ||
| // Leaving this here for future use | ||
| //if !meta.IsStatusConditionTrue(wp.Status.Conditions, "Available") { |
| wpName := fmt.Sprintf("kuadrant-%s", gwName) | ||
| wasmPluginKey := client.ObjectKey{Name: wpName, Namespace: testNamespace} | ||
| wasmPluginKey := client.ObjectKey{Name: rlptools.WASMPluginName(gateway), Namespace: testNamespace} | ||
| Eventually(testWasmPluginIsAvailable(wasmPluginKey), time.Minute, 5*time.Second).Should(BeTrue()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.