Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the coverage to drop by 3% #316

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Allow the coverage to drop by 3% #316

merged 1 commit into from
Nov 20, 2023

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Nov 17, 2023

having 1% lead to too many codecov status check errors

@eguzki eguzki requested a review from a team as a code owner November 17, 2023 15:52
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #316 (a502ed5) into main (aebe2ec) will increase coverage by 0.29%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   64.40%   64.69%   +0.29%     
==========================================
  Files          35       35              
  Lines        3787     3787              
==========================================
+ Hits         2439     2450      +11     
+ Misses       1154     1145       -9     
+ Partials      194      192       -2     
Flag Coverage Δ
integration 70.40% <ø> (+0.54%) ⬆️
unit 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 73.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.41% <ø> (ø)
controllers (i) 70.40% <ø> (+0.54%) ⬆️

see 5 files with indirect coverage changes

@eguzki eguzki merged commit a7c2c7f into main Nov 20, 2023
21 checks passed
@eguzki eguzki deleted the allow-codecov-drop-3 branch November 20, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants