Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix authconfig hosts when targeting gateway #310

Merged
merged 4 commits into from
Nov 20, 2023
Merged

fix authconfig hosts when targeting gateway #310

merged 4 commits into from
Nov 20, 2023

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Nov 16, 2023

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Merging #310 (e9d8106) into main (a7c2c7f) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   64.43%   64.27%   -0.16%     
==========================================
  Files          35       35              
  Lines        3787     3787              
==========================================
- Hits         2440     2434       -6     
- Misses       1153     1157       +4     
- Partials      194      196       +2
Flag Coverage Δ
integration 69.61% <100.00%> (-0.30%) ⬇️
unit 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 73.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.41% <ø> (ø)
controllers (i) 69.61% <100.00%> (-0.30%) ⬇️
Files Coverage Δ
controllers/authpolicy_authconfig.go 67.65% <100.00%> (ø)

... and 8 files with indirect coverage changes

@eguzki eguzki marked this pull request as ready for review November 17, 2023 10:08
@eguzki eguzki requested a review from a team as a code owner November 17, 2023 10:08
guicassolato
guicassolato approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 bug fixes + new test case. Nice job, @eguzki!

@guicassolato
Copy link
Contributor

2 bug fixes + new test case. Nice job, @eguzki!

Oops. Too soon.

GitHub Actions / Integration Tests

Expect(gateway.Spec.Listeners).Must undefined (type "github.com/onsi/gomega/types".Assertion has no field or method Must)

@eguzki eguzki force-pushed the fix-gateway-hosts branch 2 times, most recently from fb3709b to a9a90ea Compare November 17, 2023 11:10
didierofrivia
didierofrivia approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️ 🤟🏼

didierofrivia
didierofrivia reviewed Nov 17, 2023
View reviewed changes
controllers/authpolicy_controller_test.go
Expect(err).ToNot(HaveOccurred())

// check policy status
Eventually(testPolicyIsReady(policy), 60*time.Second, 5*time.Second).Should(BeTrue())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhmm, maybe we can't rely on the time frame provided

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the check is correct. It was rightfully saying something is wrong.

I missed adding a route. So a policy targeting a gateway without routes do not have any effect and the policy is not ready.

@eguzki
Copy link
Contributor Author

eguzki commented Nov 17, 2023 •
edited
Loading

now some auth policy controller tests are failing 🤦

@eguzki
Copy link
Contributor Author

eguzki commented Nov 17, 2023

Waiting #303 to be merged to rebase this.

@alexsnaps
Copy link
Member

@eguzki #303 is merged

@alexsnaps alexsnaps added this to the v0.5.0 milestone Nov 17, 2023
@eguzki eguzki merged commit 0c9289d into main Nov 20, 2023
21 checks passed
@eguzki eguzki deleted the fix-gateway-hosts branch November 20, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didierofrivia didierofrivia didierofrivia approved these changes

@guicassolato guicassolato guicassolato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kuadrant
Archived in project
Kuadrant Service Protection
Status: To test
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@eguzki @guicassolato @alexsnaps @didierofrivia