Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced observability for the limitador instance #301

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Enhanced observability for the limitador instance #301

merged 2 commits into from
Nov 22, 2023

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Nov 15, 2023 •
edited by alexsnaps
Loading

What

Fixes #296

  • Upgrade Limitador type to v0.6.0
  • Upgrade Limitador type to v0.7.0
  • Limitador deployment with rateLimitHeaders set to DRAFT_VERSION_03
  • Limitador: enable the exhaustive metrics

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Merging #301 (eb00067) into main (5a3be48) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   64.50%   64.44%   -0.06%     
==========================================
  Files          35       35              
  Lines        3786     3789       +3     
==========================================
  Hits         2442     2442              
- Misses       1150     1152       +2     
- Partials      194      195       +1
Flag Coverage Δ
integration 69.94% <100.00%> (-0.11%) ⬇️
unit 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 73.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.41% <ø> (ø)
controllers (i) 69.94% <100.00%> (-0.11%) ⬇️
Files Coverage Δ
controllers/kuadrant_controller.go 51.26% <100.00%> (+0.41%) ⬆️

... and 4 files with indirect coverage changes

@eguzki eguzki self-assigned this Nov 15, 2023
@eguzki eguzki added kind/enhancement New feature or request target/current labels Nov 15, 2023
@eguzki eguzki added this to the v0.5.0 milestone Nov 15, 2023
@eguzki eguzki mentioned this pull request Nov 20, 2023
Closed
@eguzki eguzki assigned alexsnaps and unassigned eguzki Nov 21, 2023
@alexsnaps alexsnaps force-pushed the limitador-deploy-exhaustive-metrics branch from ce4278d to 01c407e Compare November 21, 2023 20:21
@alexsnaps alexsnaps mentioned this pull request Nov 21, 2023
Closed
eguzki and others added 2 commits November 21, 2023 15:53
@eguzki @alexsnaps
limitador with rateLimitHeaders set to DRAFT_VERSION_03
b3ace75 
Additionally, upgrade Limitador type to v0.6.0

Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
@alexsnaps
limitador deployed with exhaustive Telemetry enabled.
eb00067 
Additionally, upgrade Limitador type to v0.7.0
and use the constant, instead of hardcoded duplicate values
for both Telemetry and rateLimitHeaders
@alexsnaps alexsnaps force-pushed the limitador-deploy-exhaustive-metrics branch 2 times, most recently from 53192b7 to eb00067 Compare November 21, 2023 22:27
@alexsnaps alexsnaps marked this pull request as ready for review November 21, 2023 22:45
@alexsnaps alexsnaps requested a review from a team as a code owner November 21, 2023 22:45
@eguzki
Copy link
Contributor Author

eguzki commented Nov 21, 2023

LGTM

@alexsnaps alexsnaps merged commit 342f3bf into main Nov 22, 2023
21 checks passed
@alexsnaps alexsnaps deleted the limitador-deploy-exhaustive-metrics branch November 22, 2023 11:54
This was referenced Nov 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guicassolato guicassolato guicassolato approved these changes

Assignees

@alexsnaps alexsnaps

Labels
kind/enhancement New feature or request
Projects
No open projects
Kuadrant Service Protection
Status: To test
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Add per RLP metrics & RL headers by default
3 participants
@eguzki @guicassolato @alexsnaps