Add mandatory Gateway API label to the policy CRDs #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicassolato
force-pushed
the
rlp-gwapi-policy-label
branch
from
9beab51
to
11b55d1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
- Coverage 64.50% 64.39% -0.11%
==========================================
Files 35 35
Lines 3806 3806
==========================================
- Hits 2455 2451 -4
- Misses 1155 1159 +4
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more.
|
guicassolato
force-pushed
the
rlp-gwapi-policy-label
branch
from
11b55d1
to
16bf5fa
Compare
eguzki
reviewed
Nov 14, 2023
| @@ -6,6 +6,7 @@ metadata: | |||
| creationTimestamp: null | |||
| labels: | |||
| app: kuadrant | |||
| gateway.networking.k8s.io/policy: inherited | |||
There was a problem hiding this comment.
inherited? Shouldn't be direct ?
There was a problem hiding this comment.
Of course! My distraction! Fixing it now.
There was a problem hiding this comment.
In fact, I've just noticed that the one in the AuthPolicy is also wrong!!!
There was a problem hiding this comment.
Fixed both, and rebased.
guicassolato
force-pushed
the
rlp-gwapi-policy-label
branch
from
16bf5fa
to
495e494
Compare
guicassolato
changed the title
eguzki
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gateway.networking.k8s.io/policylabel to the RateLimitPolicy CRDgateway.networking.k8s.io/policylabel in the AuthPolicy CRDRef.: https://github.com/youngnick/gateway-api/blob/main/geps/gep-713.md#standard-label-on-crd-objects
Closes #245.