Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation fix #284

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Indentation fix #284

merged 1 commit into from
Oct 25, 2023

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Oct 25, 2023

No description provided.

@Ygnas Ygnas requested a review from a team as a code owner October 25, 2023 13:54
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #284 (22d2334) into main (7d0f44e) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   64.76%   64.47%   -0.29%     
==========================================
  Files          35       35              
  Lines        3806     3806              
==========================================
- Hits         2465     2454      -11     
- Misses       1149     1158       +9     
- Partials      192      194       +2     
Flag Coverage Δ
integration 69.94% <ø> (-0.55%) ⬇️
unit 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 73.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.41% <ø> (ø)
controllers (i) 69.94% <ø> (-0.55%) ⬇️

see 6 files with indirect coverage changes

Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks, @Ygnas!

BTW, I should have credited this other one to @Boomatang, who spotted pretty much the same issue at another guide.

@guicassolato guicassolato merged commit 3f16979 into Kuadrant:main Oct 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants