We need to update the GWs finalizers #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
force-pushed
the
os-finalizer
branch
2 times, most recently
from
7e65a29
to
6457828
Compare
|
/cc @jsmolar |
alexsnaps
commented
Oct 18, 2023
| @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.13.0 | |||
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 64.38% 63.42% -0.97%
==========================================
Files 33 33
Lines 3204 3204
==========================================
- Hits 2063 2032 -31
- Misses 976 998 +22
- Partials 165 174 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
guicassolato
requested changes
Oct 19, 2023
alexsnaps
force-pushed
the
os-finalizer
branch
from
6457828
to
dfa4444
Compare
guicassolato
approved these changes
Oct 19, 2023
|
Other than @eguzki telling me this is nonsense, I'll merge that in my afternoon 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually don't know that this change suffice, but I think it should... Unsure how to best test that before merging.
See here, but we can discuss that tomorrow...