Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: fix flaky install of operator sdk on mac os #268

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Oct 11, 2023

Resolves: #254

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #268 (72f10e3) into main (a012052) will decrease coverage by 1.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   64.66%   63.57%   -1.10%     
==========================================
  Files          33       33              
  Lines        3204     3204              
==========================================
- Hits         2072     2037      -35     
- Misses        970      994      +24     
- Partials      162      173      +11     
Flag Coverage Δ
integration 69.92% <ø> (-2.24%) ⬇️
unit 57.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 75.90% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 57.63% <ø> (ø)
controllers (i) 69.92% <ø> (-2.24%) ⬇️

see 7 files with indirect coverage changes

@KevFan KevFan force-pushed the issues/254-2 branch 7 times, most recently from 99c9300 to fe46bc2 Compare October 11, 2023 14:29
@@ -14,6 +14,13 @@ if [ ! -f "$1" ]; then
TMP_DIR=$(mktemp -d)
cd $TMP_DIR

if [[ $OS == 'darwin' ]]; then
mkdir -p ".gnupg"
echo "Disabling ipv6 for pgp on mac"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment pointing to the issue where the solution was first proposed?

@KevFan KevFan marked this pull request as ready for review October 11, 2023 15:51
@KevFan KevFan requested a review from a team as a code owner October 11, 2023 15:51
@KevFan
Copy link
Contributor Author

KevFan commented Oct 11, 2023

Ran the Test / Test Scripts (1.20.x, macos-latest) action 20 times and all has passed so I think the changes will fix the flakiness of the workflow 🎉

image

@KevFan KevFan merged commit f82291d into Kuadrant:main Oct 11, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workflow: test scripts flaky on macos-latest
3 participants