-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow: fix flaky install of operator sdk on mac os #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 64.66% 63.57% -1.10%
==========================================
Files 33 33
Lines 3204 3204
==========================================
- Hits 2072 2037 -35
- Misses 970 994 +24
- Partials 162 173 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KevFan
force-pushed
the
issues/254-2
branch
7 times, most recently
from
October 11, 2023 14:29
99c9300
to
fe46bc2
Compare
utils/install-operator-sdk.sh
Outdated
@@ -14,6 +14,13 @@ if [ ! -f "$1" ]; then | |||
TMP_DIR=$(mktemp -d) | |||
cd $TMP_DIR | |||
|
|||
if [[ $OS == 'darwin' ]]; then | |||
mkdir -p ".gnupg" | |||
echo "Disabling ipv6 for pgp on mac" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment pointing to the issue where the solution was first proposed?
guicassolato
approved these changes
Oct 11, 2023
eguzki
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #254