Refactoring Github workflows #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didierofrivia
force-pushed
the
refactoring-gh-workflows
branch
4 times, most recently
from
affc938
to
02bb7d0
Compare
eguzki
reviewed
Apr 11, 2023
|
|
||
| jobs: | ||
| workflow-build: | ||
| if: ${{ github.ref_name =~ ^v[0-9]+\.[0-9]+\.[0-9]+(-.+)?$ }} |
There was a problem hiding this comment.
This snippet does not work??
on:
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+'There was a problem hiding this comment.
Some how it wasn't triggering in Act, that's why I change it to the job conditional. I could do that way, it might work with Github
* For `workflow_call` and `workflow_dispatch` events * Builds Kuadrant Operator image, it's bundle and catalog * Configurable by inputs
* Only triggered by cron * Sending kuadrant op version and tag (ref sha)
* Uses defaults for tags, version and dependencies
* Sends `git_ref` as op version and tag, defaults for the rest * Triggered by push to a branch that's not main nor release
* Triggered by tag creation, filtered by release regex * Passes the semantic version of the release tag * Dependencies are default for now, could be edited to be manually triggered with dependencies version inputs.
* This is replaced by the combo of caller workflows and `build-images-base` one
didierofrivia
force-pushed
the
refactoring-gh-workflows
branch
from
e6763cc
to
a00e8d1
Compare
eguzki
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR not only fixes the bundle creation and catalog verification that was failing because of a mismatch of listed dependency versions:
but also a complete refactor of every build job:
latesttag and0.0.0version to the Kuadrant Operatorlatesttagged bundleslatestbranch nametag and0.0.0version to the Kuadrant Operatorshacollected, sets version to0.0.0Notes:
build-images-basebuild-imagesworkflow was removed.