Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnspolicy: Update single cluster tests to use istio gateway class #582

Open
mikenairn opened this issue Apr 26, 2024 · 0 comments
Open

dnspolicy: Update single cluster tests to use istio gateway class #582

mikenairn opened this issue Apr 26, 2024 · 0 comments
Labels
area/tests Changes to tests only status/discussing Further information is requested

Comments

@mikenairn
Copy link
Member

What

The DNS and TLS policy integration tests currently create their own gateway class for testing purposes allowing us to just set an expected status on the gateway and assert things based on that status. Other tests, auth and rlp, do not do this and instead use istio and expect it to be running somewhere and update the gateway with the status expected after all the required pieces are deployed (gateway, httproute, deployment etc..).
We should at least have some tests that do the same with DNS and TLS, multi cluster (OCM) tests won't be able to do this since they require the status to be in a specific format only produced by MGC currently.

Pros:

  • More realistic, actually testing what will happen with a real gateway

Cons:

  • A lot slower, requires the deployment of everything (gatway, httproute, deployment etc..) to get to a point of having something to test
@mikenairn mikenairn added the area/tests Changes to tests only label May 2, 2024
@philbrookes philbrookes added the status/discussing Further information is requested label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Changes to tests only status/discussing Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants