Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSPolicy: defaultGeo should be required in the DNSPolicy spec #554

Closed
mikenairn opened this issue Apr 18, 2024 · 0 comments · Fixed by #578
Closed

DNSPolicy: defaultGeo should be required in the DNSPolicy spec #554

mikenairn opened this issue Apr 18, 2024 · 0 comments · Fixed by #578
Assignees
Labels
kind/bug Something isn't working status/discussing Further information is requested target/current

Comments

@mikenairn
Copy link
Member

mikenairn commented Apr 18, 2024

What

The defaultGeo value in spec.loadBalancing.geo should be required, and it should not be possible to create a geo section without providing it with a non zero length string.

Invalid:

spec:
  loadBalancing:
    geo: {}
  routingStrategy: loadbalanced
  targetRef:
    group: gateway.networking.k8s.io
    kind: Gateway
    name: distributed-us

It should also handle better the case where the geo for whatever reason is calculated to be an empty string. Currently it will create invalid dnsNames like .klb.distributed.managed.hcpapps.net where it should be <geocode>.klb.distributed.managed.hcpapps.net.

@mikenairn mikenairn added the kind/bug Something isn't working label Apr 18, 2024
@philbrookes philbrookes added the status/discussing Further information is requested label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working status/discussing Further information is requested target/current
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants