Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSPolicy: Update all integration tests to validate the structure of the produced DNSrecord endpoints #551

Closed
2 tasks
mikenairn opened this issue Apr 17, 2024 · 0 comments · Fixed by #613
Closed
2 tasks
Assignees
Labels
area/tests Changes to tests only
Milestone

Comments

@mikenairn
Copy link
Member

What

Add a validation function that can be called by every dnspolicy integration test to check the integrity of the DNSRecord endpoints being generated. It should test whether one dnsName (i.e. <clusterHash>-<gwHash>.klb.test.example.com) can be reached from another dnsName (test.example.com) by inspecting the dnsName and targets of each endpoint in the record.

Example pass( test.example.com -> clusterHash-gwHash.klb.test.example.com):

  1. test.example.com (klb.test.example.com)
  2. klb.test.example.com (default.klb.test.example.com)
  3. default.klb.test.example.com(clusterHash-gwHash.klb.test.example.com)
  4. clusterHash-gwHash.klb.test.example.com (127.0.0.1)

Example fail( test.example.com -> clusterHash-gwHash.klb.test.example.com):

  1. test.example.com (klb.test.example.com)
  2. klb.test.example.com (default.klb.test.example.com)
  3. clusterHash-gwHash.klb.test.example.com (127.0.0.1)

How

  • Add validation function that takes in a from -> to dnsName as input and returns true or false
  • Update all dnsPolicy integration tests that generate a DNSRecord to call this function
@maksymvavilov maksymvavilov self-assigned this May 2, 2024
@maksymvavilov maksymvavilov linked a pull request May 3, 2024 that will close this issue
@mikenairn mikenairn changed the title DNSPolicy: Update all integeration tests to validate the structure of the produced DNSrecord endpoints DNSPolicy: Update all integration tests to validate the structure of the produced DNSrecord endpoints May 9, 2024
@maleck13 maleck13 added the area/tests Changes to tests only label May 31, 2024
@maleck13 maleck13 added this to the Kuadrant v1 milestone May 31, 2024
dlaw4608 pushed a commit to dlaw4608/kuadrant-operator that referenced this issue Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Changes to tests only
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants