Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create label to trigger Quay images job #241

Open
didierofrivia opened this issue Aug 30, 2023 · 3 comments
Open

Create label to trigger Quay images job #241

didierofrivia opened this issue Aug 30, 2023 · 3 comments
Labels

Comments

@didierofrivia
Copy link
Collaborator

Currently we're facing mainly 2 issues:

  1. Images overflow in our quay.io repo
  2. Pull requests coming from forks cannot trigger the build and push of the images

It would be good to have a label or a comment that administrators of Kuadrant org can assign to any PR in order to allow the trigger of the required quay job.

This needs to be applied to every Kuadrant repo.

Something that's been used by k8s that could be of help is https://prow.k8s.io/command-help#ok_to_test.

@didierofrivia didierofrivia changed the title Create label to trigger Quay images Create label to trigger Quay images job Aug 30, 2023
@Boomatang
Copy link
Contributor

I am not sure how much the ok_to_test label that k8s uses will help. K8s uses prow and not github actions. I am not say that github actions can't do the same, its more any prow feature would need to be researched to find the equivalent github action feature. A scan of https://github.com/marketplace/actions/label-actions shows that it is possible to do the triggers on labels. If it is enough for what we want, that is a different question.

@alexsnaps alexsnaps added this to the v0.5.0 milestone Sep 12, 2023
@alexsnaps alexsnaps removed this from the v0.5.0 milestone Nov 10, 2023
@alexsnaps
Copy link
Member

@didierofrivia is this still relevant in the light of the upcoming RFC?

@didierofrivia
Copy link
Collaborator Author

I'd say it is, since the RFC even if it's finished before the holidays, after reviewing and adjustments, it most probably will end up being implemented in March.

@dlaw4608 dlaw4608 self-assigned this Jun 20, 2024
dlaw4608 pushed a commit to dlaw4608/kuadrant-operator that referenced this issue Jul 17, 2024
---

Fix PR build and push for forks (Closes Kuadrant#241)
dlaw4608 pushed a commit to dlaw4608/kuadrant-operator that referenced this issue Jul 18, 2024
---

Fix PR build and push for forks (Closes Kuadrant#241)
@dlaw4608 dlaw4608 removed their assignment Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Status: To do
Development

No branches or pull requests

4 participants