Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: upgrade to go 1.20 #236

Closed
KevFan opened this issue Aug 24, 2023 · 2 comments · Fixed by #239
Closed

tool: upgrade to go 1.20 #236

KevFan opened this issue Aug 24, 2023 · 2 comments · Fixed by #239
Assignees
Labels
good first issue Good for newcomers kind/enhancement New feature or request size/small

Comments

@KevFan
Copy link
Contributor

KevFan commented Aug 24, 2023

As a pre-req to #203, we should upgrade to Go 1.20

Things to consider on this upgrade:

  • Workflows should be updated to this version
  • Consider any functions that can be simplified from new functions natively provided by Go 1.20
  • Any go.mod / go.sum changes
@KevFan
Copy link
Contributor Author

KevFan commented Aug 28, 2023

@guicassolato do you have any thoughts on whether we want to use the experimental slices package (https://pkg.go.dev/golang.org/x/exp@v0.0.0-20230817173708-d852ddb80c63/slices) to remove / simplify https://github.com/Kuadrant/kuadrant-operator/blob/main/pkg/common/common.go#L92-L189

This slice package is provided as part of Go 1.21 standard library https://pkg.go.dev/slices@go1.21.0 but is not available in Go 1.20

@guicassolato
Copy link
Contributor

@guicassolato do you have any thoughts on whether we want to use the experimental slices package

It's a shame it doesn't include a few generic functions we depend on (e.g. common.Map, common.Filter, common.Intersect, common.Intersection), but many others are there. So let's use it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request size/small
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants