Improve test coverage for package common #167
Assignees
Labels
good first issue
Good for newcomers
Comments
art-tapin
added a commit
that referenced
this issue
Apr 21, 2023
art-tapin
added a commit
that referenced
this issue
Apr 21, 2023
art-tapin
added a commit
that referenced
this issue
Apr 24, 2023
art-tapin
added a commit
that referenced
this issue
Apr 25, 2023
art-tapin
added a commit
that referenced
this issue
Apr 25, 2023
art-tapin
added a commit
that referenced
this issue
Apr 25, 2023
art-tapin
added a commit
that referenced
this issue
Apr 25, 2023
- wildcards with different TLDs - wildcards at different levels in domain hierarchy - wildcards with subdomains - empty hostnames - one empty hostname - multiple wildcards
art-tapin
added a commit
that referenced
this issue
Apr 25, 2023
art-tapin
added a commit
that referenced
this issue
Apr 26, 2023
art-tapin
added a commit
that referenced
this issue
Apr 26, 2023
art-tapin
added a commit
that referenced
this issue
Apr 26, 2023
art-tapin
added a commit
that referenced
this issue
Apr 26, 2023
art-tapin
added a commit
that referenced
this issue
Apr 26, 2023
art-tapin
added a commit
that referenced
this issue
Apr 26, 2023
art-tapin
added a commit
that referenced
this issue
Apr 26, 2023
art-tapin
added a commit
that referenced
this issue
Apr 26, 2023
- wildcards with different TLDs - wildcards at different levels in domain hierarchy - wildcards with subdomains - empty hostnames - one empty hostname - multiple wildcards
art-tapin
added a commit
that referenced
this issue
Apr 26, 2023
This was referenced Apr 27, 2023
art-tapin
added a commit
that referenced
this issue
Apr 28, 2023
…onditions (#172) * test: Add unit tests for CopyConditions function (#167) * refactor: change the test name according to function name (#167) * test: Add unit tests for ConditionMarshal function (#167) * test: Refactor test namings (#167) * refactor: optimize CopyConditions and reuse it in ConditionMarshal - Refactored CopyConditions function to avoid unnecessary appends and allocate slice with exact length - Reused CopyConditions in ConditionMarshal instead of using append for performance improvement and null safety * refactor: fix test-case according to optimisation in ConditionMarshal (#167) * refactor: run goimports && gofmt && refactoring according to lint
art-tapin
added a commit
that referenced
this issue
Apr 28, 2023
* test: Add unit tests for FindAuthorinoStatusCondition function (#167) * refactor: run goimports && gofmt
art-tapin
added a commit
that referenced
this issue
Apr 28, 2023
art-tapin
added a commit
that referenced
this issue
Apr 28, 2023
art-tapin
added a commit
that referenced
this issue
Apr 28, 2023
art-tapin
added a commit
that referenced
this issue
Apr 28, 2023
art-tapin
added a commit
that referenced
this issue
Apr 28, 2023
art-tapin
added a commit
that referenced
this issue
May 29, 2023
didierofrivia
pushed a commit
that referenced
this issue
May 31, 2023
…go (part 1 of 3) (#176) * test: Add unit-tests for FetchEnv (#167) * refactor: Add comment for FetchEnv() (#167) * refactor: Add unit-tests for GetDefaultIfNil (#167) * refactor: Add comment for GetDefaultIfNil (#167) * test: Add unit-tests for GetEmptySliceIfNil (#167) * refactor: Add comment for GetEmptySliceIfNil (#167) * test: Add unit-tests for NamespacedNameToObjectKey (#167) + "sigs.k8s.io/controller-runtime/pkg/client" added as an import * refactor: optimize NamespacedNameToObjectKey function for improved performance (#167) Refactored the NamespacedNameToObjectKey function to improve its performance by switching from using the strings.Split() function to using the strings.IndexRune() function. This new implementation is approximately 12-13 times faster for large datasets than the previous implementation. * refactor: delete three meaningless test cases for FetchEnv (#167) - empty environment variable name is not expected - one of the cases was a duplication of an existing one * refactor: get rid two test-cases because of redundancy
didierofrivia
pushed a commit
that referenced
this issue
May 31, 2023
…go (part 2 of 3) (#182) * test: Add unit-tests for Contains (#167) * refactor: Add comment to Contains (#167) * test: Add unit-tests for Map (#167) * refactor: Add comment to Map (#167) * refactor: Add names to Map test cases (#167) * test: Add unit-tests for SliceCopy (#167) * refactor: Add comment to SliceCopy (#167) * test: Add unit-tests for ReverseSlice (#167) * refactor: Add comment to ReverseSlice (#167) * test: Add unit-tests for MergeMapStringString (#167) * refactor: Add missing import 'reflect'
didierofrivia
pushed a commit
that referenced
this issue
May 31, 2023
* optimisation: Improve performance of UnMarshallObjectKey This commit optimizes the UnMarshallObjectKey function by avoiding unnecessary allocations and using a simple string split operation instead of manual string parsing. This results in performance improvements when processing large volumes of Kubernetes objects. Additionally, the function now validates input strings more accurately to prevent errors when working with invalid object keys. * optimisation: Improve performance of UnMarshallLimitNamespace This commit optimizes the UnMarshallLimitNamespace function to improve its runtime performance. The following changes were made: - Used strings.IndexByte instead of strings.Split to search for the index of the '#' delimiter character, reducing the number of iterations and memory allocation overhead. - Extracted the domain directly from the input string instead of creating a temporary slice, reducing the number of string allocations. - Passed only the first half of the input string to UnMarshallObjectKey function, avoiding the creation of unnecessary intermediate strings. * optimisation: improve performance of HostnamesToStrings (#167) - Pre-allocated output slice using make function to reduce append overhead * refactor: Replace errors.New(...) with fmt.Errorf(...) * refactor: Simplify if-condition in UnMarshallObjectKey to handle empty namespace and name values + refactor the error message * fix: Use IndexRune instead of IndexByte to handle non-ascii characters in UnMarshallLimitNamespace and UnMarshallObjectKey Discussion: #187 (comment) Kudos to Eguzki * [test] Unit-tests for common/common.go (part 3 of 3) (#186) * test: Add unit-tests for UnMarshallLimitNamespace (#167) * test: Add two FAILING unit-tests for UnMarshallLimitNamespace (#167) The two failing test cases include: - when namespace has no gateway name then return an error - when namespace has no domain name then return an error In these test-cases we leave the separator (either "/" or "#"), which causes the function to return an error when the gateway name or domain name is missing. In the last two test cases: - when namespace only has gateway name (missing 'namespace/') and domain then return an error - when namespace only has namespace name (missing '/gwName') and domain then return an error the separator (/) is missing along with the namespace or gateway names, causing the function to return the correct error message. * refactor: Add comment to UnMarshallLimitNamespace (#167) * test: Add unit-tests for MarshallNamespace (#167) * test: Add unit-tests for UnMarshallObjectKey (#167) * test: Add unit-tests for HostnamesToStrings (#167) * [test] Optimizations, improvements, and unit tests for common/common.go (part 2 of 3) (#182) * test: Add unit-tests for Contains (#167) * refactor: Add comment to Contains (#167) * test: Add unit-tests for Map (#167) * refactor: Add comment to Map (#167) * refactor: Add names to Map test cases (#167) * test: Add unit-tests for SliceCopy (#167) * refactor: Add comment to SliceCopy (#167) * test: Add unit-tests for ReverseSlice (#167) * refactor: Add comment to ReverseSlice (#167) * test: Add unit-tests for MergeMapStringString (#167) * refactor: Add missing import 'reflect' * fix: Ensure Istio gateways created in the tests are ready ('Programmed') by setting ClusterIP service type (#185) * changelog (#184) * test: Add two test-cases for UnMarshallObjectKey (#167) 1. when valid namespace and empty name (strKey ends with '/') then return valid ObjectKey with namespace only 2. when valid name and empty namespace (strKey starts with '/') then return valid ObjectKey with name only Changes were discussed here: #187 (comment) * test: Delete test case for UnMarshallLimitNamespace The test case "when namespace has no gateway name then return an error" has been removed from the test suite for UnMarshallLimitNamespace. This test case was tightly connected to the implementation of UnMarshallObjectKey, making it impossible to properly test the desired behavior in the context of UnMarshallLimitNamespace. * refactor: Add clarity to the test name Describing the '/' separator as a default one we show that it is a default constant value. --------- Co-authored-by: Guilherme Cassolato <guicassolato@gmail.com> Co-authored-by: Eguzki Astiz Lezaun <eastizle@redhat.com> --------- Co-authored-by: Guilherme Cassolato <guicassolato@gmail.com> Co-authored-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
didierofrivia
pushed a commit
that referenced
this issue
May 31, 2023
* test: Add unit-tests to ObjectInfo (#167) * refactor: Add comment to ObjectInfo (#167) * test: Add unit-test to ReadAnnotationsFromObject (#167) * refactor: Add comment to ReadAnnotationsFromObject (#167) * test: Add unit-test to TagObjectToDelete (#167) * refactor: Add comment to TagObjectToDelete (#167) * test: Add unit-tests to IsObjectTaggedToDelete (#167) * refactor: Add comment to IsObjectTaggedToDelete (#167) * refactor: run goimporst to pass the code-style check (#167) * refactor: Rename 'Kind' fields according to CamelCase naming convention * refactor: Simplify comment to ObjectInfo (#167) * refactor: Compare maps with DeepEqual instead of looping in TestTagObjectToDelete (#167) * refactor: Clean the tests for ObjectInfo (#167) - Deleted redundant test-case (#190 (comment)) - Generalized the names of objects to 'Kubernetes object' in test-case names kudos to @guicassolato!
didierofrivia
pushed a commit
that referenced
this issue
Jun 2, 2023
art-tapin
added a commit
that referenced
this issue
Jun 12, 2023
art-tapin
added a commit
that referenced
this issue
Jun 12, 2023
art-tapin
added a commit
that referenced
this issue
Jun 12, 2023
art-tapin
added a commit
that referenced
this issue
Jun 12, 2023
art-tapin
added a commit
that referenced
this issue
Jun 12, 2023
art-tapin
added a commit
that referenced
this issue
Jun 12, 2023
art-tapin
added a commit
that referenced
this issue
Jun 12, 2023
…mmediately (#167) With this change, the function terminates execution upon encountering a decoding error, providing more accurate error handling. This ensures that errors are not accumulated and allows the caller to handle the error appropriately. See: #195 (comment)
art-tapin
added a commit
that referenced
this issue
Jun 13, 2023
art-tapin
added a commit
that referenced
this issue
Jun 15, 2023
- when inputA and inputB have no common elements then return inputA as the result
art-tapin
added a commit
that referenced
this issue
Jun 15, 2023
art-tapin
added a commit
that referenced
this issue
Jun 15, 2023
art-tapin
added a commit
that referenced
this issue
Jun 15, 2023
art-tapin
added a commit
that referenced
this issue
Jun 15, 2023
art-tapin
added a commit
that referenced
this issue
Jun 15, 2023
art-tapin
added a commit
that referenced
this issue
Jun 15, 2023
art-tapin
added a commit
that referenced
this issue
Jun 15, 2023
- Refactor logger initialisation and document decoding to fail fast and return errors immediately - Enhanced empty doc check - Add comment to the function
art-tapin
added a commit
that referenced
this issue
Jun 21, 2023
… and improvements for common/yaml_decoder.go (#195) * test: Add test-case to TestObjectKeyListDifference (#167) - when inputA and inputB have no common elements then return inputA as the result * refactor: Rename tests for ObjectKeyListDifference (#167) * test: Add unit-tests to ContainsObjectKey (#167) * test: Add unit-tests to FindObjectKey (#167) * test: Add unit-tests to FindDeploymentStatusCondition (#167) * refactor: Clarify test name in TestStatusConditionsMarshalJSON (#167) * test: Add unit-tests to DecodeFile (#167) * refactor, improvements: DecodeFile YAML decoder (#167) - Refactor logger initialisation and document decoding to fail fast and return errors immediately - Enhanced empty doc check - Add comment to the function
guicassolato
added a commit
that referenced
this issue
Jun 21, 2023
* Build images with replaces image (#193) * [makefile] Updating the `replaces` directive in CSV * [gh workflow] Adding `replacesVersion` as input for workflow_dispatch * [config] Adding default replaces operator value * [bundle] Updated bundle * Building the catalog with the replaces directive (#194) * [catalog] Building the catalog with the replaces directive * [catalog] Setting default replaces version to `0.0.0-alpha` * [bundle] Updating config and bundle with new default release version * upgrade operator-sdk v1.28.1 * fix verify-bundle task * Create a ServiceMeshMember, rather than mutating the ServiceMeshMemberRoll * Fixed access to servicemeshmember * [test] Unit-tests for common/k8s_utils.go (part 2 of 3) (#191) * test: Add unit-tests to StatusConditionsMarshalJSON (#167) * test: Add unit-tests to IsOwnedBy (#167) * refactor: Add comment to IsOwnedBy (#167) * test: Add unit-test to GetServicePortNumber (#167) * Update gateway-api module to v0.6.2 (#153) * Update gateway api dep to v0.6.2 Update controller runtime Set go version 1.19 Use github.com/onsi/ginkgo/v2 which is used by the latest version if controller-runtime (envtest). * Update GatewayClass, Gateway and HTTPRoute to v1beta1 Since v0.6.0 GatewayClass, Gateway and HTTPRoute have moved to the v1beta1 version of the API and support in v1alpha2 will be removed eventually. All references to these APIS are now updated to use v1beta1. PolicyTargetReference are still v1alpha2. * [test] Unit-tests for common/k8s_utils.go (part 3 of 3) & Unit-tests and improvements for common/yaml_decoder.go (#195) * test: Add test-case to TestObjectKeyListDifference (#167) - when inputA and inputB have no common elements then return inputA as the result * refactor: Rename tests for ObjectKeyListDifference (#167) * test: Add unit-tests to ContainsObjectKey (#167) * test: Add unit-tests to FindObjectKey (#167) * test: Add unit-tests to FindDeploymentStatusCondition (#167) * refactor: Clarify test name in TestStatusConditionsMarshalJSON (#167) * test: Add unit-tests to DecodeFile (#167) * refactor, improvements: DecodeFile YAML decoder (#167) - Refactor logger initialisation and document decoding to fail fast and return errors immediately - Enhanced empty doc check - Add comment to the function --------- Co-authored-by: dd di cesare <4183971+didierofrivia@users.noreply.github.com> Co-authored-by: Eguzki Astiz Lezaun <eastizle@redhat.com> Co-authored-by: Alex Snaps <alex@wcgw.dev> Co-authored-by: artem_tiupin <70763601+art-tapin@users.noreply.github.com> Co-authored-by: Michael Nairn <mnairn@redhat.com>
guicassolato
added a commit
that referenced
this issue
Jul 14, 2023
* Build images with replaces image (#193) * [makefile] Updating the `replaces` directive in CSV * [gh workflow] Adding `replacesVersion` as input for workflow_dispatch * [config] Adding default replaces operator value * [bundle] Updated bundle * Building the catalog with the replaces directive (#194) * [catalog] Building the catalog with the replaces directive * [catalog] Setting default replaces version to `0.0.0-alpha` * [bundle] Updating config and bundle with new default release version * upgrade operator-sdk v1.28.1 * fix verify-bundle task * Create a ServiceMeshMember, rather than mutating the ServiceMeshMemberRoll * Fixed access to servicemeshmember * [test] Unit-tests for common/k8s_utils.go (part 2 of 3) (#191) * test: Add unit-tests to StatusConditionsMarshalJSON (#167) * test: Add unit-tests to IsOwnedBy (#167) * refactor: Add comment to IsOwnedBy (#167) * test: Add unit-test to GetServicePortNumber (#167) * Update gateway-api module to v0.6.2 (#153) * Update gateway api dep to v0.6.2 Update controller runtime Set go version 1.19 Use github.com/onsi/ginkgo/v2 which is used by the latest version if controller-runtime (envtest). * Update GatewayClass, Gateway and HTTPRoute to v1beta1 Since v0.6.0 GatewayClass, Gateway and HTTPRoute have moved to the v1beta1 version of the API and support in v1alpha2 will be removed eventually. All references to these APIS are now updated to use v1beta1. PolicyTargetReference are still v1alpha2. * [test] Unit-tests for common/k8s_utils.go (part 3 of 3) & Unit-tests and improvements for common/yaml_decoder.go (#195) * test: Add test-case to TestObjectKeyListDifference (#167) - when inputA and inputB have no common elements then return inputA as the result * refactor: Rename tests for ObjectKeyListDifference (#167) * test: Add unit-tests to ContainsObjectKey (#167) * test: Add unit-tests to FindObjectKey (#167) * test: Add unit-tests to FindDeploymentStatusCondition (#167) * refactor: Clarify test name in TestStatusConditionsMarshalJSON (#167) * test: Add unit-tests to DecodeFile (#167) * refactor, improvements: DecodeFile YAML decoder (#167) - Refactor logger initialisation and document decoding to fail fast and return errors immediately - Enhanced empty doc check - Add comment to the function * [istio] Updating registerIstioExternalAuthorizer * Reconciles also the Istio ConfigMap with the external authorizers * If the IstioOperator CR returns an error, it continues reconciling CM * [istio] Updating the unregisterExternalAuthorizerIstio * With the new functionality * [mesh config] Refactoring and testing mesh config functionality * [makefile] Splitting local deploy in different target * [istio] Refactoring using wrapper structs * [go] Fixing dependencies * [mesh config] Refactoring mesh config objects and fns * [controller] Fixing registering logic * Still relying on the istio CRD being installed. If not, means no istio * If it's 404, means it's installed other way than it's operator * If any other error happens, istio is installed, but an error occurred * [controller] Refactoring istio installation process * Added ENV for CM name * [refactor] Using apierrors.IsNotFound instead of crafting the error msg * kind: bump to 0.20.0 and pin image to kindest/node:v1.27.3 (#209) * Upgrade Authorino and Authorino Operator to latest (#211) * Authorino v0.14.0 * Authorino Operator v0.8.0 * workflow: use go1.19 to align with go.mod go version used (#213) * workflow: use go1.19 to align with go.mod go version used * doc: fix operator-sdk & kind versions used for development --------- Co-authored-by: dd di cesare <4183971+didierofrivia@users.noreply.github.com> Co-authored-by: Eguzki Astiz Lezaun <eastizle@redhat.com> Co-authored-by: Alex Snaps <alex@wcgw.dev> Co-authored-by: artem_tiupin <70763601+art-tapin@users.noreply.github.com> Co-authored-by: Michael Nairn <mnairn@redhat.com> Co-authored-by: dd di cesare <didi@posteo.net> Co-authored-by: Kevin Fan <chfan@redhat.com>
KevFan
pushed a commit
to KevFan/kuadrant-operator
that referenced
this issue
Aug 10, 2023
* Build images with replaces image (Kuadrant#193) * [makefile] Updating the `replaces` directive in CSV * [gh workflow] Adding `replacesVersion` as input for workflow_dispatch * [config] Adding default replaces operator value * [bundle] Updated bundle * Building the catalog with the replaces directive (Kuadrant#194) * [catalog] Building the catalog with the replaces directive * [catalog] Setting default replaces version to `0.0.0-alpha` * [bundle] Updating config and bundle with new default release version * upgrade operator-sdk v1.28.1 * fix verify-bundle task * Create a ServiceMeshMember, rather than mutating the ServiceMeshMemberRoll * Fixed access to servicemeshmember * [test] Unit-tests for common/k8s_utils.go (part 2 of 3) (Kuadrant#191) * test: Add unit-tests to StatusConditionsMarshalJSON (Kuadrant#167) * test: Add unit-tests to IsOwnedBy (Kuadrant#167) * refactor: Add comment to IsOwnedBy (Kuadrant#167) * test: Add unit-test to GetServicePortNumber (Kuadrant#167) * Update gateway-api module to v0.6.2 (Kuadrant#153) * Update gateway api dep to v0.6.2 Update controller runtime Set go version 1.19 Use github.com/onsi/ginkgo/v2 which is used by the latest version if controller-runtime (envtest). * Update GatewayClass, Gateway and HTTPRoute to v1beta1 Since v0.6.0 GatewayClass, Gateway and HTTPRoute have moved to the v1beta1 version of the API and support in v1alpha2 will be removed eventually. All references to these APIS are now updated to use v1beta1. PolicyTargetReference are still v1alpha2. * [test] Unit-tests for common/k8s_utils.go (part 3 of 3) & Unit-tests and improvements for common/yaml_decoder.go (Kuadrant#195) * test: Add test-case to TestObjectKeyListDifference (Kuadrant#167) - when inputA and inputB have no common elements then return inputA as the result * refactor: Rename tests for ObjectKeyListDifference (Kuadrant#167) * test: Add unit-tests to ContainsObjectKey (Kuadrant#167) * test: Add unit-tests to FindObjectKey (Kuadrant#167) * test: Add unit-tests to FindDeploymentStatusCondition (Kuadrant#167) * refactor: Clarify test name in TestStatusConditionsMarshalJSON (Kuadrant#167) * test: Add unit-tests to DecodeFile (Kuadrant#167) * refactor, improvements: DecodeFile YAML decoder (Kuadrant#167) - Refactor logger initialisation and document decoding to fail fast and return errors immediately - Enhanced empty doc check - Add comment to the function --------- Co-authored-by: dd di cesare <4183971+didierofrivia@users.noreply.github.com> Co-authored-by: Eguzki Astiz Lezaun <eastizle@redhat.com> Co-authored-by: Alex Snaps <alex@wcgw.dev> Co-authored-by: artem_tiupin <70763601+art-tapin@users.noreply.github.com> Co-authored-by: Michael Nairn <mnairn@redhat.com>
KevFan
pushed a commit
to KevFan/kuadrant-operator
that referenced
this issue
Aug 14, 2023
* Build images with replaces image (Kuadrant#193) * [makefile] Updating the `replaces` directive in CSV * [gh workflow] Adding `replacesVersion` as input for workflow_dispatch * [config] Adding default replaces operator value * [bundle] Updated bundle * Building the catalog with the replaces directive (Kuadrant#194) * [catalog] Building the catalog with the replaces directive * [catalog] Setting default replaces version to `0.0.0-alpha` * [bundle] Updating config and bundle with new default release version * upgrade operator-sdk v1.28.1 * fix verify-bundle task * Create a ServiceMeshMember, rather than mutating the ServiceMeshMemberRoll * Fixed access to servicemeshmember * [test] Unit-tests for common/k8s_utils.go (part 2 of 3) (Kuadrant#191) * test: Add unit-tests to StatusConditionsMarshalJSON (Kuadrant#167) * test: Add unit-tests to IsOwnedBy (Kuadrant#167) * refactor: Add comment to IsOwnedBy (Kuadrant#167) * test: Add unit-test to GetServicePortNumber (Kuadrant#167) * Update gateway-api module to v0.6.2 (Kuadrant#153) * Update gateway api dep to v0.6.2 Update controller runtime Set go version 1.19 Use github.com/onsi/ginkgo/v2 which is used by the latest version if controller-runtime (envtest). * Update GatewayClass, Gateway and HTTPRoute to v1beta1 Since v0.6.0 GatewayClass, Gateway and HTTPRoute have moved to the v1beta1 version of the API and support in v1alpha2 will be removed eventually. All references to these APIS are now updated to use v1beta1. PolicyTargetReference are still v1alpha2. * [test] Unit-tests for common/k8s_utils.go (part 3 of 3) & Unit-tests and improvements for common/yaml_decoder.go (Kuadrant#195) * test: Add test-case to TestObjectKeyListDifference (Kuadrant#167) - when inputA and inputB have no common elements then return inputA as the result * refactor: Rename tests for ObjectKeyListDifference (Kuadrant#167) * test: Add unit-tests to ContainsObjectKey (Kuadrant#167) * test: Add unit-tests to FindObjectKey (Kuadrant#167) * test: Add unit-tests to FindDeploymentStatusCondition (Kuadrant#167) * refactor: Clarify test name in TestStatusConditionsMarshalJSON (Kuadrant#167) * test: Add unit-tests to DecodeFile (Kuadrant#167) * refactor, improvements: DecodeFile YAML decoder (Kuadrant#167) - Refactor logger initialisation and document decoding to fail fast and return errors immediately - Enhanced empty doc check - Add comment to the function --------- Co-authored-by: dd di cesare <4183971+didierofrivia@users.noreply.github.com> Co-authored-by: Eguzki Astiz Lezaun <eastizle@redhat.com> Co-authored-by: Alex Snaps <alex@wcgw.dev> Co-authored-by: artem_tiupin <70763601+art-tapin@users.noreply.github.com> Co-authored-by: Michael Nairn <mnairn@redhat.com>
KevFan
pushed a commit
to KevFan/kuadrant-operator
that referenced
this issue
Aug 14, 2023
* Build images with replaces image (Kuadrant#193) * [makefile] Updating the `replaces` directive in CSV * [gh workflow] Adding `replacesVersion` as input for workflow_dispatch * [config] Adding default replaces operator value * [bundle] Updated bundle * Building the catalog with the replaces directive (Kuadrant#194) * [catalog] Building the catalog with the replaces directive * [catalog] Setting default replaces version to `0.0.0-alpha` * [bundle] Updating config and bundle with new default release version * upgrade operator-sdk v1.28.1 * fix verify-bundle task * Create a ServiceMeshMember, rather than mutating the ServiceMeshMemberRoll * Fixed access to servicemeshmember * [test] Unit-tests for common/k8s_utils.go (part 2 of 3) (Kuadrant#191) * test: Add unit-tests to StatusConditionsMarshalJSON (Kuadrant#167) * test: Add unit-tests to IsOwnedBy (Kuadrant#167) * refactor: Add comment to IsOwnedBy (Kuadrant#167) * test: Add unit-test to GetServicePortNumber (Kuadrant#167) * Update gateway-api module to v0.6.2 (Kuadrant#153) * Update gateway api dep to v0.6.2 Update controller runtime Set go version 1.19 Use github.com/onsi/ginkgo/v2 which is used by the latest version if controller-runtime (envtest). * Update GatewayClass, Gateway and HTTPRoute to v1beta1 Since v0.6.0 GatewayClass, Gateway and HTTPRoute have moved to the v1beta1 version of the API and support in v1alpha2 will be removed eventually. All references to these APIS are now updated to use v1beta1. PolicyTargetReference are still v1alpha2. * [test] Unit-tests for common/k8s_utils.go (part 3 of 3) & Unit-tests and improvements for common/yaml_decoder.go (Kuadrant#195) * test: Add test-case to TestObjectKeyListDifference (Kuadrant#167) - when inputA and inputB have no common elements then return inputA as the result * refactor: Rename tests for ObjectKeyListDifference (Kuadrant#167) * test: Add unit-tests to ContainsObjectKey (Kuadrant#167) * test: Add unit-tests to FindObjectKey (Kuadrant#167) * test: Add unit-tests to FindDeploymentStatusCondition (Kuadrant#167) * refactor: Clarify test name in TestStatusConditionsMarshalJSON (Kuadrant#167) * test: Add unit-tests to DecodeFile (Kuadrant#167) * refactor, improvements: DecodeFile YAML decoder (Kuadrant#167) - Refactor logger initialisation and document decoding to fail fast and return errors immediately - Enhanced empty doc check - Add comment to the function --------- Co-authored-by: dd di cesare <4183971+didierofrivia@users.noreply.github.com> Co-authored-by: Eguzki Astiz Lezaun <eastizle@redhat.com> Co-authored-by: Alex Snaps <alex@wcgw.dev> Co-authored-by: artem_tiupin <70763601+art-tapin@users.noreply.github.com> Co-authored-by: Michael Nairn <mnairn@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the test coverage it's 52.0% of statements, ideally the percentage should be the closest to 100% we can achieve.
The following functions are currently not tested:
The text was updated successfully, but these errors were encountered: