refactor, improvements: DecodeFile YAML decoder (#167)

- Refactor logger initialisation and document decoding to fail fast and return errors immediately
- Enhanced empty doc check
- Add comment to the function

pkg/common/yaml_decoder.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"errors"
+	"fmt"
 	"io"
 
 	"github.com/go-logr/logr"
@@ -14,11 +15,17 @@ import (
 
 type DecodeCallback = func(runtime.Object) error
 
+// DecodeFile decodes the provided file data (encoded YAML documents) into Kubernetes objects using the specified scheme,
+// and invokes the callback function for each decoded object. Returns an error if any decoding error occurs.
 func DecodeFile(ctx context.Context, fileData []byte, scheme *runtime.Scheme, cb DecodeCallback) error {
-	logger, _ := logr.FromContext(ctx)
+	logger, logErr := logr.FromContext(ctx)
 	codec := serializer.NewCodecFactory(scheme)
 	decoder := codec.UniversalDeserializer()
 
+	if logErr != nil {
+		return logErr
+	}
+
 	// the maximum size used to buffer a doc 5M
 	buf := make([]byte, 5*1024*1024)
 	docDecoder := yaml.NewDocumentDecoder(io.NopCloser(bytes.NewReader(fileData)))
@@ -32,16 +39,16 @@ func DecodeFile(ctx context.Context, fileData []byte, scheme *runtime.Scheme, cb
 			return err
 		}
 
-		if n == 0 {
-			// empty docs
+		if n == 0 || string(fileData) == "---" {
+			// Skip empty docs
 			continue
 		}
 
 		docData := buf[:n]
 		obj, _, err := decoder.Decode(docData, nil, nil)
 		if err != nil {
 			logger.Info("Document decode error", "error", err)
-			continue
+			return fmt.Errorf("failed to decode document: %w", err)
 		}
 
 		err = cb(obj)