refactor: Refactor document decoding to fail fast and return errors i…

…mmediately (#167)

With this change, the function terminates execution upon encountering a decoding error, providing more accurate error handling. This ensures that errors are not accumulated and allows the caller to handle the error appropriately.

See: #195 (comment)

pkg/common/yaml_decoder.go

@@ -30,7 +30,6 @@ func DecodeFile(ctx context.Context, fileData []byte, scheme *runtime.Scheme, cb
 	buf := make([]byte, 5*1024*1024)
 	docDecoder := yaml.NewDocumentDecoder(io.NopCloser(bytes.NewReader(fileData)))
 
-	hasError := false
 	for {
 		n, err := docDecoder.Read(buf)
 		if err != nil {
@@ -49,17 +48,13 @@ func DecodeFile(ctx context.Context, fileData []byte, scheme *runtime.Scheme, cb
 		obj, _, err := decoder.Decode(docData, nil, nil)
 		if err != nil {
 			logger.Info("Document decode error", "error", err)
-			hasError = true
-			continue
+			return fmt.Errorf("failed to decode document: %w", err)
 		}
 
 		err = cb(obj)
 		if err != nil {
 			return err
 		}
 	}
-	if hasError {
-		return fmt.Errorf("one or more document decoding errors occurred. See the logs for more details")
-	}
 	return nil
 }