[gh workflow] Separating variables between build workflow and callers

* Passing as input variables in caller workflow * Removing conditionals from build images
Kuadrant · Mar 28, 2023 · 511decd · 511decd
1 parent 2291ff7
commit 511decd
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 25 deletions.
diff --git a/.github/workflows/build-images.yaml b/.github/workflows/build-images.yaml
@@ -5,19 +5,26 @@ on:
     branches: ['*']
     tags: ['*']
   workflow_call:
+    inputs:
+      authorinoOperatorBundleVersion:
+        description: Authorino Operator bundle version
+        default: latest
+      limitadorOperatorBundleVersion:
+        description: Limitador Operator bundle version
+        default: latest
+      wasmShimVersion:
+        description: WASM Shim version
+        default: latest
   workflow_dispatch:
     inputs:
       authorinoOperatorBundleVersion:
         description: Authorino Operator bundle version
-        required: true
         default: latest
       limitadorOperatorBundleVersion:
         description: Limitador Operator bundle version
-        required: true
         default: latest
       wasmShimVersion:
         description: WASM Shim version
-        required: true
         default: latest
 
 env:
@@ -110,34 +117,17 @@ jobs:
           else
           echo "VERSION=${{ github.sha }}" >> $GITHUB_ENV
           fi
-      - name: Add SHA tags if triggered by scheduled workflow
-        if: ${{ github.event_name == "workflow_call" }}
-        id: set-dependencies-sha-tags
-        run: |
-          echo "Setting dependencies image versions from stored variables..."
-          echo "AUTHORINO_OPERATOR_VERSION=${vars.AUTHORINO_OPERATOR_BUNDLE_SHA}" >> $GITHUB_ENV
-          echo "LIMITADOR_OPERATOR_VERSION=${vars.LIMITADOR_OPERATOR_BUNDLE_SHA}  >> $GITHUB_ENV
-          echo "WASM_SHIM_VERSION=${vars.WASM_SHIM_SHA}  >> $GITHUB_ENV
-      - name: Add specific tags if triggered by workflow dispatch
-        if: ${{ github.event_name == "workflow_dispatch" }}
-        id: set-dependencies-specific-tags
-        run: |
-          echo "Setting dependencies image versions from user input..."
-          echo "AUTHORINO_OPERATOR_VERSION=${github.event.inputs.authorinoOperatorBundleVersion}" >> $GITHUB_ENV
-          echo "LIMITADOR_OPERATOR_VERSION=${github.event.inputs.limitadorOperatorBundleVersion}  >> $GITHUB_ENV
-          echo "WASM_SHIM_VERSION=${github.event.inputs.wasmShimVersion}  >> $GITHUB_ENV
       - name: Install qemu dependency
         run: |
           sudo apt-get update
           sudo apt-get install -y qemu-user-static
       - name: Run make bundle
         run: |
-          if [[ ${github.event_name} == "workflow_call" || ${github.event_name} == "workflow_dispatch" ]]; then
-          echo "Building bundle via workflow call"
-          make bundle REGISTRY=${{ env.IMG_REGISTRY_HOST }} ORG=${{ env.IMG_REGISTRY_ORG }} VERSION=${TAG_NAME/v/} AUTHORINO_OPERATOR_VERSION=${env.AUTHORINO_OPERATOR_VERSION} LIMITADOR_OPERATOR_VERSION=${env.LIMITADOR_OPERATOR_VERSION} WASM_SHIM_VERSION=${env.WASM_SHIM_VERSION}
-          else
-          make bundle REGISTRY=${{ env.IMG_REGISTRY_HOST }} ORG=${{ env.IMG_REGISTRY_ORG }} IMAGE_TAG=${{ github.ref_name }}
-          fi
+          make bundle REGISTRY=${{ env.IMG_REGISTRY_HOST }} ORG=${{ env.IMG_REGISTRY_ORG }} \
+            VERSION=${TAG_NAME/v/} IMAGE_TAG=${{ github.sha }} \
+            AUTHORINO_OPERATOR_VERSION=${github.event.inputs.authorinoOperatorBundleVersion} \
+            LIMITADOR_OPERATOR_VERSION=${github.event.inputs.limitadorOperatorBundleVersion} \
+            WASM_SHIM_VERSION=${github.event.inputs.wasmShimVersion}
       - name: Build Image
         id: build-image
         uses: redhat-actions/buildah-build@v2

diff --git a/.github/workflows/scheduled-build.yaml b/.github/workflows/scheduled-build.yaml
@@ -11,3 +11,7 @@ jobs:
   workflow-build:
     name: Calls build-images workflow
     uses: ./.github/workflows/build-images.yaml
+    with:
+      authorinoOperatorBundleVersion: ${vars.AUTHORINO_OPERATOR_BUNDLE_SHA}
+      limitadorOperatorBundleVersion: ${vars.LIMITADOR_OPERATOR_BUNDLE_SHA}
+      wasmShimVersion: ${vars.WASM_SHIM_SHA}