Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harden DNSRecord clean up when namespaces deleted #106

Closed
maleck13 opened this issue May 2, 2024 · 1 comment · Fixed by #156
Closed

harden DNSRecord clean up when namespaces deleted #106

maleck13 opened this issue May 2, 2024 · 1 comment · Fixed by #156
Assignees
Labels
enhancement New feature or request size/large
Milestone

Comments

@maleck13
Copy link
Collaborator

maleck13 commented May 2, 2024

What

Sometimes it seems possible for the ManagedZone to get deleted before the DNSRecords are removed. Seems we need to make sure the DNSRecords are removed before removing any finalizers on other objects (secrets, zones etc).

review event trigger relationships between all objects, (e.g. if mz secret is changed reconcile mz and related dns records).

Objects to consider:

  • secret for managed zone
  • managed zone
  • dns policies
  • dns records

If DNS Record or DNS Policy is deleting and the secret is absent, the DNS Record or DNS Policy should not have it's finalizer removed.

DNS Record finalizers should only be removed if the controller has confirmed removal of those records from the provider.

If a DNS Record or Policy reconciles and the secret is absent, take actions:

  • A clear log entry
  • Emit a metric
  • Investigate - Can we update status on namespace in this scenario.
@philbrookes philbrookes added size/large enhancement New feature or request labels May 2, 2024
@philbrookes philbrookes self-assigned this May 21, 2024
@maleck13 maleck13 added this to the Kuadrant v1 milestone May 31, 2024
@philbrookes
Copy link
Collaborator

PR: #156

github-merge-queue bot pushed a commit that referenced this issue Jun 13, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 8, 2024
Owned DNS Records will block Managed Zone deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/large
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants