Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Authorino enable/disable superseding strict host subsets #143

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

guicassolato
Copy link
Collaborator

Exposes Authorino's --allow-superseding-host-subsets command-line flag (Kuadrant/authorino#434) as a new API option spec.supersedingHostSubsets: Boolean (default: false)

Verification steps

kind create cluster --name authorino-operator-test
kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.12.1/cert-manager.yaml
kubectl -n cert-manager wait --timeout=300s --for=condition=Available deployments --all
kubectl create namespace authorino-operator
make install
make run

In a separate shell:

kubectl apply -f -<<EOF
apiVersion: operator.authorino.kuadrant.io/v1beta1
kind: Authorino
metadata:
  name: authorino
spec:
  supersedingHostSubsets: true
  image: quay.io/kuadrant/authorino:host-collision-switch
  listener:
    tls:
      enabled: false
  oidcServer:
    tls:
      enabled: false
EOF

Confirm the --allow-superseding-host-subsets flag included in the command-line args of the Authorino container:

kubectl get deployment/authorino -o jsonpath='{.spec.template.spec.containers[0].args}'
# ["--watch-namespace=default","--allow-superseding-host-subsets"]%

Exposes Authorino's `--allow-superseding-host-subsets` command-line flag (Kuadrant/authorino#434) as a new API option `spec.supersedingHostSubsets: Boolean` (default: `false`)
@guicassolato guicassolato self-assigned this Sep 29, 2023
@guicassolato guicassolato requested a review from a team September 29, 2023 17:19
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #143 (3cb0cef) into main (45f17d5) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   63.11%   62.85%   -0.26%     
==========================================
  Files           1        1              
  Lines         732      735       +3     
==========================================
  Hits          462      462              
- Misses        220      222       +2     
- Partials       50       51       +1     
Flag Coverage Δ
unit 62.85% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/authorino_controller.go 62.85% <0.00%> (-0.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me 👍

image

@guicassolato guicassolato merged commit edce84b into main Oct 2, 2023
8 checks passed
@guicassolato guicassolato deleted the host-collision-switch branch October 2, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants